From 12db6b444373d77c3124bf4c40fef4d295b1176f Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Fri, 12 Mar 2021 09:18:06 +0100 Subject: [PATCH] Remove redundant `cache being stopped` check Signed-off-by: Michal Mielewczyk --- casadm/extended_err_msg.c | 5 ----- modules/cas_cache/layer_cache_management.c | 15 --------------- modules/include/cas_ioctl_codes.h | 3 --- 3 files changed, 23 deletions(-) diff --git a/casadm/extended_err_msg.c b/casadm/extended_err_msg.c index dd8b1c9..18354a4 100644 --- a/casadm/extended_err_msg.c +++ b/casadm/extended_err_msg.c @@ -253,11 +253,6 @@ struct { "Waiting for operation interrupted" }, { - KCAS_ERR_CACHE_STOPPING, - "Cache being stopped" - }, - { - KCAS_ERR_CORE_IN_ACTIVE_STATE, "Core device is in active state" }, diff --git a/modules/cas_cache/layer_cache_management.c b/modules/cas_cache/layer_cache_management.c index 9f0ad9d..1f12432 100644 --- a/modules/cas_cache/layer_cache_management.c +++ b/modules/cas_cache/layer_cache_management.c @@ -98,13 +98,6 @@ static int _cache_mngt_lock_sync(ocf_cache_t cache) struct _cache_mngt_async_context *context; int result; - if (!ocf_cache_is_running(cache)) { - printk(KERN_WARNING "%s is being stopped. " - "Can't perform management operations\n", - ocf_cache_get_name(cache)); - return -KCAS_ERR_CACHE_STOPPING; - } - context = kmalloc(sizeof(*context), GFP_KERNEL); if (!context) return -ENOMEM; @@ -142,13 +135,6 @@ static int _cache_mngt_read_lock_sync(ocf_cache_t cache) struct _cache_mngt_async_context *context; int result; - if (!ocf_cache_is_running(cache)) { - printk(KERN_WARNING "%s is being stopped. " - "Can't perform management operations\n", - ocf_cache_get_name(cache)); - return -KCAS_ERR_CACHE_STOPPING; - } - context = kmalloc(sizeof(*context), GFP_KERNEL); if (!context) return -ENOMEM; @@ -2432,7 +2418,6 @@ int cache_mngt_exit_instance(const char *cache_name, size_t name_len, int flush) case -OCF_ERR_CACHE_IN_INCOMPLETE_STATE: case -OCF_ERR_FLUSHING_INTERRUPTED: case -KCAS_ERR_WAITING_INTERRUPTED: - case -KCAS_ERR_CACHE_STOPPING: goto put; default: flush_status = status; diff --git a/modules/include/cas_ioctl_codes.h b/modules/include/cas_ioctl_codes.h index 4ef1358..bb2517a 100644 --- a/modules/include/cas_ioctl_codes.h +++ b/modules/include/cas_ioctl_codes.h @@ -598,9 +598,6 @@ enum kcas_error { /** Waiting for async operation was interrupted */ KCAS_ERR_WAITING_INTERRUPTED, - /** Cache already being stopped*/ - KCAS_ERR_CACHE_STOPPING, - /** Core device is in active state */ KCAS_ERR_CORE_IN_ACTIVE_STATE };