github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1064 from Deixx/is-it-a-fix

Browse Source 
Stopping unplugged cache - changed behavior
This commit is contained in:
Karolina Rogowska 2022-02-18 15:10:44 +01:00 committed by GitHub
commit 12f7355316
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/functional/tests/lazy_writes/recovery/test_recovery_unplug.py
View File

@ -76,9 +76,19 @@ def test_recovery_unplug_cache_fs(cache_mode, cls, filesystem, direct):
f"{cache.get_dirty_blocks().get_value(Unit.Blocks4096)}") f"{cache.get_dirty_blocks().get_value(Unit.Blocks4096)}")
with TestRun.step("Stop cache."): with TestRun.step("Stop cache."):
cache.stop() try:
cache.stop()
TestRun.fail("Stopping the cache should be aborted without --no-flush flag.")
except CmdException as e:
TestRun.LOGGER.info(str(e.output))
try:
cache.stop(no_data_flush=True)
TestRun.LOGGER.warning("Expected stopping cache with errors with --no-flush flag.")
except CmdException as e1:
cli_messages.check_stderr_msg(e1.output, cli_messages.stop_cache_errors)
with TestRun.step("Plug missing cache device."): with TestRun.step("Plug missing cache device."):
TestRun.LOGGER.info(str(casadm.list_caches(by_id_path=False)))
cache_disk.plug() cache_disk.plug()
with TestRun.step("Load cache."): with TestRun.step("Load cache."):
@ -152,12 +162,18 @@ def test_recovery_unplug_cache_raw(cache_mode, cls):
with TestRun.step("Stop cache."): with TestRun.step("Stop cache."):
try: try:
cache.stop(no_data_flush=True) cache.stop()
TestRun.LOGGER.warning("Expected stopping cache with errors.") TestRun.fail("Stopping the cache should be aborted without --no-flush flag.")
except CmdException as e: except CmdException as e:
cli_messages.check_stderr_msg(e.output, cli_messages.stop_cache_errors) TestRun.LOGGER.info(str(e.output))
try:
cache.stop(no_data_flush=True)
TestRun.LOGGER.warning("Expected stopping cache with errors with --no-flush flag.")
except CmdException as e1:
cli_messages.check_stderr_msg(e1.output, cli_messages.stop_cache_errors)
with TestRun.step("Plug missing cache device."): with TestRun.step("Plug missing cache device."):
TestRun.LOGGER.info(str(casadm.list_caches(by_id_path=False)))
cache_disk.plug() cache_disk.plug()
with TestRun.step("Load cache."): with TestRun.step("Load cache."):