Merge pull request #898 from karolinavelkaja/cleanup_framework_eviction_policy

cleanup framework - eviction policy
This commit is contained in:
Robert Baldyga
2021-08-20 10:21:32 +02:00
committed by GitHub
4 changed files with 8 additions and 36 deletions

View File

@@ -40,11 +40,6 @@ class Cache:
cp = stats.config_stats.cleaning_policy
return CleaningPolicy[cp]
def get_eviction_policy(self):
stats = self.get_statistics()
ep = stats.config_stats.eviction_policy
return EvictionPolicy[ep]
def get_metadata_mode(self):
if self.__metadata_mode is None:
stats = self.get_statistics()
@@ -183,5 +178,4 @@ class Cache:
return CacheConfig(self.get_cache_line_size(),
self.get_cache_mode(),
self.get_cleaning_policy(),
self.get_eviction_policy(),
self.get_metadata_mode())

View File

@@ -82,14 +82,6 @@ class SeqCutOffPolicy(Enum):
raise ValueError(f"{name} is not a valid sequential cut off name")
class EvictionPolicy(Enum):
lru = "LRU"
DEFAULT = lru
def __str__(self):
return self.value
class MetadataMode(Enum):
normal = "normal"
atomic = "atomic"
@@ -378,14 +370,12 @@ class CacheConfig:
cache_line_size=CacheLineSize.DEFAULT,
cache_mode=CacheMode.DEFAULT,
cleaning_policy=CleaningPolicy.DEFAULT,
eviction_policy=EvictionPolicy.DEFAULT,
metadata_mode=MetadataMode.normal,
kernel_parameters=None
):
self.cache_line_size = cache_line_size
self.cache_mode = cache_mode
self.cleaning_policy = cleaning_policy
self.eviction_policy = eviction_policy
self.metadata_mode = metadata_mode
self.kernel_parameters = kernel_parameters
@@ -394,7 +384,6 @@ class CacheConfig:
self.cache_line_size == other.cache_line_size
and self.cache_mode == other.cache_mode
and self.cleaning_policy == other.cleaning_policy
and self.eviction_policy == other.eviction_policy
and self.metadata_mode == other.metadata_mode
and equal_or_default(
self.kernel_parameters, other.kernel_parameters, KernelParameters.DEFAULT