github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't try to restore cache after stop error.

Browse Source 
In current OCF cache stop implemetation no error should occur, so there is no
need to handle it in adapter.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2019-12-23 11:09:43 -05:00
parent 232f13a8a4
commit 36e34b5a69
1 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
modules/cas_cache/layer_cache_management.c
View File

@ -291,7 +291,7 @@ static int exit_instance_finish(ocf_cache_t cache, int error)
mngt_queue = cache_priv->mngt_queue; mngt_queue = cache_priv->mngt_queue;
if (error && error != -OCF_ERR_WRITE_CACHE) if (error && error != -OCF_ERR_WRITE_CACHE)
goto restore_exp_obj; BUG_ON(error);
if (!error && flush_status) if (!error && flush_status)
error = -KCAS_ERR_STOPPED_DIRTY; error = -KCAS_ERR_STOPPED_DIRTY;
@ -307,25 +307,6 @@ static int exit_instance_finish(ocf_cache_t cache, int error)
ocf_queue_put(mngt_queue); ocf_queue_put(mngt_queue);
return error; return error;
restore_exp_obj:
if (block_dev_create_all_exported_objects(cache)) {
/* Print error msg but do not change return err code to inform user why
* stop failed originally. */
printk(KERN_WARNING
"Failed to restore (create) all exported objects!\n");
goto unlock;
}
if (block_dev_activate_all_exported_objects(cache)) {
block_dev_destroy_all_exported_objects(cache);
printk(KERN_WARNING
"Failed to restore (activate) all exported objects!\n");
}
unlock:
ocf_mngt_cache_unlock(cache);
ocf_mngt_cache_put(cache);
module_put(THIS_MODULE);
return error;
} }
struct _cache_mngt_attach_context { struct _cache_mngt_attach_context {