github/open-cas-linux
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Integrate kmemleak into CAS

Browse Source 
Kmemleak is a tool which allows to detect memory leaks in kernel. It requires
`CONFIG_DEBUG_KMEMLEAK` to be enabled during kernel compilation. Otherwise all
the kmemleak_* functions are NOPs.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk
2022-08-12 10:25:55 +02:00
parent 90106d545a
commit 38bef1f7fe
3 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/cas_cache/context.c
View File

@@ -1,5 +1,5 @@
/*
* Copyright(c) 2012-2021 Intel Corporation
* Copyright(c) 2012-2022 Intel Corporation
* SPDX-License-Identifier: BSD-3-Clause
*/
@@ -10,6 +10,7 @@
#include "utils/utils_gc.h"
#include "utils/utils_mpool.h"
#include "threads.h"
#include <linux/kmemleak.h>
struct env_mpool *cas_bvec_pool;
@@ -66,6 +67,7 @@ void *_cas_alloc_page_rpool(void *allocator_ctx, int cpu)
_cas_page_set_priv(page);
_cas_page_set_cpu(page, cpu);
return page_address(page);
}
@@ -103,6 +105,11 @@ ctx_data_t *__cas_ctx_data_alloc(uint32_t pages, bool zalloc)
_cas_page_set_cpu(data->vec[i].bv_page, cpu);
} else {
data->vec[i].bv_page = alloc_page(GFP_NOIO);
if (data->vec[i].bv_page) {
/* Failed to get memory from rpool but backup allocation worked.
Need to keep track of this page as well */
kmemleak_alloc(page_address(data->vec[i].bv_page), PAGE_SIZE, 1, GFP_NOIO);
}
}
if (!data->vec[i].bv_page)
@@ -171,8 +178,11 @@ void cas_ctx_data_free(ctx_data_t *ctx_data)
if (!(_cas_page_test_priv(page) && !cas_rpool_try_put(
cas_bvec_pages_rpool,
page_address(page),
_cas_page_get_cpu(page))))
_cas_page_get_cpu(page)))) {
__free_page(page);
/* It wasn't a page from rpool thus need to stop tracking it explicitly */
kmemleak_free(page_address(page));
}
}
env_mpool_del(cas_bvec_pool, data, data->size);