github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #268 from mmichal10/fix_mem_leak

Browse Source 
Free memory of all allocated threads.
This commit is contained in:
Jan Musiał 2020-01-16 09:26:26 +01:00 committed by GitHub
commit 51bb7677f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/cas_cache/threads.c
View File

@ -52,8 +52,10 @@ static int _cas_io_queue_thread(void *data)
/* If we get here, then thread was signalled to terminate. /* If we get here, then thread was signalled to terminate.
* So, let's free memory and exit. * So, let's free memory and exit.
*/ */
wait_for_completion(&info->compl);
printk(KERN_DEBUG "Thread %s stopped\n", info->name); printk(KERN_DEBUG "Thread %s stopped\n", info->name);
kfree(info); kfree(info);
do_exit(0);
return 0; return 0;
} }
@ -112,7 +114,9 @@ static int _cas_cleaner_thread(void *data)
} }
} while (true); } while (true);
complete_and_exit(&info->compl, 0); wait_for_completion(&info->compl);
kfree(info);
do_exit(0);
return 0; return 0;
} }
@ -144,7 +148,9 @@ static int _cas_metadata_updater_thread(void *data)
atomic_read(&info->kicked)); atomic_read(&info->kicked));
} while (true); } while (true);
complete_and_exit(&info->compl, 0); wait_for_completion(&info->compl);
kfree(info);
do_exit(0);
return 0; return 0;
} }
@ -202,8 +208,10 @@ static void _cas_start_thread(struct cas_thread_info *info)
static void _cas_stop_thread(struct cas_thread_info *info) static void _cas_stop_thread(struct cas_thread_info *info)
{ {
if (info->running && info->thread) { if (info->running && info->thread) {
reinit_completion(&info->compl);
atomic_set(&info->stop, 1); atomic_set(&info->stop, 1);
wake_up(&info->wq); wake_up(&info->wq);
complete(&info->compl);
} }
} }