From 5f81173844bd96add1897521a28e446326a9a7f0 Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Tue, 17 Sep 2019 09:12:49 -0400 Subject: [PATCH] Leave space for terminating \0 in cache name initialization. Signed-off-by: Michal Mielewczyk --- modules/cas_cache/layer_cache_management.c | 2 +- modules/cas_cache/layer_upgrade.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/cas_cache/layer_cache_management.c b/modules/cas_cache/layer_cache_management.c index 770d0d2..8495617 100644 --- a/modules/cas_cache/layer_cache_management.c +++ b/modules/cas_cache/layer_cache_management.c @@ -1060,7 +1060,7 @@ int cache_mngt_prepare_cache_cfg(struct ocf_mngt_cache_config *cfg, memset(device_cfg, 0, sizeof(*device_cfg)); memset(atomic_params, 0, sizeof(*atomic_params)); - strncpy(cfg->name, cache_name, OCF_CACHE_NAME_SIZE); + strncpy(cfg->name, cache_name, OCF_CACHE_NAME_SIZE - 1); cfg->cache_mode = cmd->caching_mode; cfg->cache_line_size = cmd->line_size; cfg->eviction_policy = cmd->eviction_policy; diff --git a/modules/cas_cache/layer_upgrade.c b/modules/cas_cache/layer_upgrade.c index 93980aa..f612f0a 100644 --- a/modules/cas_cache/layer_upgrade.c +++ b/modules/cas_cache/layer_upgrade.c @@ -861,7 +861,7 @@ static int _cas_upgrade_restore_conf_main(struct cas_properties *cache_props, if (cache_mode >= ocf_cache_mode_max) cache_mode = ocf_cache_mode_default; - strncpy(cfg.name, cache_name, OCF_CACHE_NAME_SIZE); + strncpy(cfg.name, cache_name, OCF_CACHE_NAME_SIZE - 1); cfg.cache_mode = cache_mode; /* cfg.eviction_policy = TODO */ cfg.cache_line_size = cache_line_size;