From 6c57d2827f20c89e23e60c5ad279ad818a29f74e Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Wed, 29 Jan 2020 10:12:09 -0500 Subject: [PATCH] Fix restoring old CAS version when upgrade failed Signed-off-by: Michal Mielewczyk --- utils/upgrade_utils.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/utils/upgrade_utils.py b/utils/upgrade_utils.py index 3fffffb..7e2112e 100644 --- a/utils/upgrade_utils.py +++ b/utils/upgrade_utils.py @@ -162,9 +162,10 @@ class UpgradeState: def insert_module(name, installed=True, **params): cmd_params = [f"{param}={val}" for param, val in params.items()] - cmd = "modprobe --first-time" if installed else "insmod" + cmd = ["modprobe", "--first-time"] if installed else ["insmod"] + cmd += [name] + cmd_params - p = subprocess.run([cmd, name] + cmd_params, stdout=subprocess.PIPE, stderr=subprocess.PIPE) + p = subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) if p.returncode: raise Exception(p.stderr.decode("ascii").rstrip("\n"))