github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cas_disk: handle allocation error properly

Browse Source 
In case of error `blk_mq_init_queue()` does not return NULL, but
`ERR_PTR(error_code)` instead.

`IS_ERR_OR_NULL()` should be used to check if `blk_mq_init_queue()` actually
failed.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2020-07-07 06:57:17 -04:00
parent 9c6a4a393c
commit 8363b67993
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/cas_disk/exp_obj.c
View File

@ -557,8 +557,8 @@ int casdsk_exp_obj_create(struct casdsk_disk *dsk, const char *dev_name,
} }
queue = blk_mq_init_queue(&dsk->tag_set); queue = blk_mq_init_queue(&dsk->tag_set);
if (!queue) { if (IS_ERR_OR_NULL(queue)) {
result = -ENOMEM; result = queue ? PTR_ERR(queue) : -ENOMEM;
goto error_init_queue; goto error_init_queue;
} }