github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable changing cache params for detached cache

Browse Source 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Michal Mielewczyk 2023-10-05 14:06:32 +02:00 committed by Rafal Stefanowski
parent bb8fc64ed5
commit 8724c29413
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
modules/cas_cache/layer_cache_management.c
View File

@ -1271,7 +1271,10 @@ static int cache_mngt_update_core_uuid(ocf_cache_t cache, const char *core_name,
if (result) if (result)
return result; return result;
return _cache_mngt_save_sync(cache); if (ocf_cache_is_device_attached(cache))
result = _cache_mngt_save_sync(cache);
return result;
} }
static void _cache_mngt_log_core_device_path(ocf_core_t core) static void _cache_mngt_log_core_device_path(ocf_core_t core)
@ -1717,7 +1720,12 @@ int cache_mngt_set_partitions(const char *cache_name, size_t name_len,
if (ocf_cache_is_standby(cache)) { if (ocf_cache_is_standby(cache)) {
result = -OCF_ERR_CACHE_STANDBY; result = -OCF_ERR_CACHE_STANDBY;
goto out_standby; goto out_not_running;
}
if (!ocf_cache_is_device_attached(cache)) {
result = -OCF_ERR_CACHE_DETACHED;
goto out_not_running;
} }
for (class_id = 0; class_id < OCF_USER_IO_CLASS_MAX; class_id++) { for (class_id = 0; class_id < OCF_USER_IO_CLASS_MAX; class_id++) {
@ -1752,7 +1760,7 @@ out_cls:
while (class_id--) while (class_id--)
cas_cls_rule_destroy(cache, cls_rule[class_id]); cas_cls_rule_destroy(cache, cls_rule[class_id]);
} }
out_standby: out_not_running:
ocf_mngt_cache_put(cache); ocf_mngt_cache_put(cache);
out_get: out_get:
kfree(io_class_cfg); kfree(io_class_cfg);
@ -2947,6 +2955,11 @@ int cache_mngt_set_cache_mode(const char *cache_name, size_t name_len,
goto put; goto put;
} }
if (!ocf_cache_is_device_attached(cache)) {
result = -OCF_ERR_CACHE_DETACHED;
goto put;
}
old_mode = ocf_cache_get_mode(cache); old_mode = ocf_cache_get_mode(cache);
if (old_mode == mode) { if (old_mode == mode) {
printk(KERN_INFO "%s is in requested cache mode already\n", cache_name); printk(KERN_INFO "%s is in requested cache mode already\n", cache_name);