github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Warning for standby activate with inactive core

Browse Source 
Signed-off-by: Piotr Debski <piotr.debski@intel.com>
This commit is contained in:
Piotr Debski 2022-03-26 02:55:42 +01:00
parent 77c11b040a
commit 8ec9bd3d93
2 changed files with 39 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
casadm/cas_lib.c
View File

@ -974,8 +974,7 @@ int start_cache(uint16_t cache_id, unsigned int cache_init,
{ {
int fd = 0; int fd = 0;
struct kcas_start_cache cmd; struct kcas_start_cache cmd;
struct cache_device *cache; int status;
int i, status;
double min_free_ram_gb; double min_free_ram_gb;
/* check if cache device given exists */ /* check if cache device given exists */
@ -1039,30 +1038,7 @@ int start_cache(uint16_t cache_id, unsigned int cache_init,
status = SUCCESS; status = SUCCESS;
for (i = 0; i < CORE_ADD_MAX_TIMEOUT; ++i) { check_cache_state_incomplete(cache_id, fd);
cache = get_cache_device_by_id_fd(cache_id, fd, false);
status = FAILURE;
if (cache == NULL) {
break;
}
if (cache->core_count == cache->expected_core_count) {
if (cache->state & (1 << ocf_cache_state_incomplete)) {
cas_printf(LOG_WARNING, "WARNING: Cache is in incomplete state - at least one core is inactive\n");
}
status = SUCCESS;
free(cache);
cache = NULL;
break;
}
free(cache);
cache = NULL;
sleep(1);
}
close(fd); close(fd);
if (status == SUCCESS) { if (status == SUCCESS) {
@ -1849,6 +1825,33 @@ int remove_core(unsigned int cache_id, unsigned int core_id,
return SUCCESS; return SUCCESS;
} }
void check_cache_state_incomplete(int cache_id, int fd) {
struct cache_device *cache;
int i;
for (i = 0; i < CORE_ADD_MAX_TIMEOUT; i++) {
cache = get_cache_device_by_id_fd(cache_id, fd, false);
if (cache == NULL) {
return;
}
if (cache->core_count == cache->expected_core_count) {
if (cache->state & (1 << ocf_cache_state_incomplete)) {
cas_printf(LOG_WARNING, "WARNING: Cache is in incomplete state - at least one core is inactive\n");
}
free(cache);
cache = NULL;
return;
}
free(cache);
cache = NULL;
sleep(1);
}
}
int remove_inactive_core(unsigned int cache_id, unsigned int core_id, int remove_inactive_core(unsigned int cache_id, unsigned int core_id,
bool force) bool force)
{ {
@ -3028,6 +3031,7 @@ int standby_detach(int cache_id)
int standby_activate(int cache_id, const char *cache_device) int standby_activate(int cache_id, const char *cache_device)
{ {
int fd = 0;
struct kcas_standby_activate cmd = { struct kcas_standby_activate cmd = {
.cache_id = cache_id .cache_id = cache_id
}; };
@ -3047,6 +3051,13 @@ int standby_activate(int cache_id, const char *cache_device)
return FAILURE; return FAILURE;
} }
fd = open_ctrl_device();
if(fd == -1)
return FAILURE;
check_cache_state_incomplete(cache_id, fd);
close(fd);
cas_printf(LOG_INFO, "Successfully activated cache instance %hu\n", cas_printf(LOG_INFO, "Successfully activated cache instance %hu\n",
cache_id); cache_id);

2
casadm/cas_lib.h
View File

@ -249,6 +249,8 @@ int standby_detach(int cache_id);
*/ */
int standby_activate(int cache_id, const char *cache_device); int standby_activate(int cache_id, const char *cache_device);
void check_cache_state_incomplete(int cache_id, int fd);
/** /**
* @brief remove inactive core device from a cache * @brief remove inactive core device from a cache
* *