github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Keep pointer to rollback thread in start_finalize

Browse Source 
If cache is initialized successfully, `struct _cache_mngt_attach_context` might
be freed in `cache_mngt_init_instance()`. In such case pointer to rollback
thread can't be accessed and thread can't be stopped.

To prevent such scenario pointer should be kept in separate variable.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2020-06-15 10:26:26 -04:00
parent f0594dce3a
commit 975ec6f32a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/cas_cache/layer_cache_management.c
View File

@ -1848,6 +1848,7 @@ static void cache_start_finalize(struct work_struct *work)
{ {
struct cache_priv *cache_priv = struct cache_priv *cache_priv =
container_of(work, struct cache_priv, start_worker); container_of(work, struct cache_priv, start_worker);
struct task_struct *rollback_thread;
struct _cache_mngt_attach_context *ctx = cache_priv->attach_context; struct _cache_mngt_attach_context *ctx = cache_priv->attach_context;
int result; int result;
ocf_cache_t cache = ctx->cache; ocf_cache_t cache = ctx->cache;
@ -1870,6 +1871,8 @@ static void cache_start_finalize(struct work_struct *work)
init_instance_complete(ctx, cache); init_instance_complete(ctx, cache);
rollback_thread = ctx->rollback_thread;
if (_cache_mngt_async_callee_set_result(&ctx->async, 0)) { if (_cache_mngt_async_callee_set_result(&ctx->async, 0)) {
/* caller interrupted */ /* caller interrupted */
ctx->ocf_start_error = 0; ctx->ocf_start_error = 0;
@ -1878,7 +1881,7 @@ static void cache_start_finalize(struct work_struct *work)
return; return;
} }
kthread_stop(ctx->rollback_thread); kthread_stop(rollback_thread);
ocf_mngt_cache_unlock(cache); ocf_mngt_cache_unlock(cache);
} }