github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #106 from imjfckm/fix-puts

Browse Source 
Remove unneccessary cache_puts
This commit is contained in:
Michal Rakowski 2019-09-19 12:55:34 +02:00 committed by GitHub
commit b3dd5ead36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
modules/cas_cache/layer_cache_management.c
View File

@ -271,10 +271,8 @@ int cache_mngt_set_cleaning_policy(ocf_cache_t cache, uint32_t type)
int result; int result;
result = _cache_mngt_lock_sync(cache); result = _cache_mngt_lock_sync(cache);
if (result) { if (result)
ocf_mngt_cache_put(cache);
return result; return result;
}
result = ocf_mngt_cache_cleaning_set_policy(cache, type); result = ocf_mngt_cache_cleaning_set_policy(cache, type);
if (result) if (result)
@ -293,10 +291,8 @@ int cache_mngt_get_cleaning_policy(ocf_cache_t cache, uint32_t *type)
int result; int result;
result = _cache_mngt_read_lock_sync(cache); result = _cache_mngt_read_lock_sync(cache);
if (result) { if (result)
ocf_mngt_cache_put(cache);
return result; return result;
}
result = ocf_mngt_cache_cleaning_get_policy(cache, &tmp_type); result = ocf_mngt_cache_cleaning_get_policy(cache, &tmp_type);
@ -313,10 +309,8 @@ int cache_mngt_set_cleaning_param(ocf_cache_t cache, ocf_cleaning_t type,
int result; int result;
result = _cache_mngt_lock_sync(cache); result = _cache_mngt_lock_sync(cache);
if (result) { if (result)
ocf_mngt_cache_put(cache);
return result; return result;
}
result = ocf_mngt_cache_cleaning_set_param(cache, type, result = ocf_mngt_cache_cleaning_set_param(cache, type,
param_id, param_value); param_id, param_value);
@ -336,10 +330,8 @@ int cache_mngt_get_cleaning_param(ocf_cache_t cache, ocf_cleaning_t type,
int result; int result;
result = _cache_mngt_read_lock_sync(cache); result = _cache_mngt_read_lock_sync(cache);
if (result) { if (result)
ocf_mngt_cache_put(cache);
return result; return result;
}
result = ocf_mngt_cache_cleaning_get_param(cache, type, result = ocf_mngt_cache_cleaning_get_param(cache, type,
param_id, param_value); param_id, param_value);
@ -1575,12 +1567,15 @@ int cache_mngt_get_seq_cutoff_threshold(ocf_core_t core, uint32_t *thresh)
int result; int result;
result = _cache_mngt_read_lock_sync(cache); result = _cache_mngt_read_lock_sync(cache);
if (result) if (result) {
ocf_mngt_cache_put(cache);
return result; return result;
}
result = ocf_mngt_core_get_seq_cutoff_threshold(core, thresh); result = ocf_mngt_core_get_seq_cutoff_threshold(core, thresh);
ocf_mngt_cache_read_unlock(cache); ocf_mngt_cache_read_unlock(cache);
ocf_mngt_cache_put(cache);
return result; return result;
} }
@ -1599,12 +1594,15 @@ int cache_mngt_get_seq_cutoff_policy(ocf_core_t core,
int result; int result;
result = _cache_mngt_read_lock_sync(cache); result = _cache_mngt_read_lock_sync(cache);
if (result) if (result) {
ocf_mngt_cache_put(cache);
return result; return result;
}
result = ocf_mngt_core_get_seq_cutoff_policy(core, policy); result = ocf_mngt_core_get_seq_cutoff_policy(core, policy);
ocf_mngt_cache_read_unlock(cache); ocf_mngt_cache_read_unlock(cache);
ocf_mngt_cache_put(cache);
return result; return result;
} }