github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Access attach command conditionaly

Browse Source 
If cache is restored after upgrade, NULL is passed instead of
`struct kcas_start_cache`. This leads to null pointer dereference.

To prevent null pointer dereference, `struct kcas_start_cache` is tested before
each use

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2020-06-16 04:01:54 -04:00
parent 975ec6f32a
commit c71b5fcbd3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/cas_cache/layer_cache_management.c
View File

@ -1836,7 +1836,7 @@ static void init_instance_complete(struct _cache_mngt_attach_context *ctx,
/* Set other back information */ /* Set other back information */
name = block_dev_get_elevator_name( name = block_dev_get_elevator_name(
casdsk_disk_get_queue(bd_cache_obj->dsk)); casdsk_disk_get_queue(bd_cache_obj->dsk));
if (name) if (name && ctx->cmd)
strlcpy(ctx->cmd->cache_elevator, strlcpy(ctx->cmd->cache_elevator,
name, MAX_ELEVATOR_NAME); name, MAX_ELEVATOR_NAME);
} }
@ -1893,7 +1893,7 @@ static void _cache_mngt_start_complete(ocf_cache_t cache, void *priv, int error)
int caller_status = _cache_mngt_async_callee_peek_result(&ctx->async); int caller_status = _cache_mngt_async_callee_peek_result(&ctx->async);
if (caller_status || error) { if (caller_status || error) {
if (error == -OCF_ERR_NO_FREE_RAM) { if (error == -OCF_ERR_NO_FREE_RAM && ctx->cmd) {
ocf_mngt_get_ram_needed(cache, ctx->device_cfg, ocf_mngt_get_ram_needed(cache, ctx->device_cfg,
&ctx->cmd->min_free_ram); &ctx->cmd->min_free_ram);
} else if (caller_status == -KCAS_ERR_WAITING_INTERRUPTED) { } else if (caller_status == -KCAS_ERR_WAITING_INTERRUPTED) {