From cefa6ab121f2909775bbd9bd6ad0484eb1c34973 Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Thu, 26 Sep 2024 16:27:27 +0200 Subject: [PATCH] Add missing volume_destroy() in attach Signed-off-by: Michal Mielewczyk --- modules/cas_cache/layer_cache_management.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/modules/cas_cache/layer_cache_management.c b/modules/cas_cache/layer_cache_management.c index 8c206c1..7c11d3a 100644 --- a/modules/cas_cache/layer_cache_management.c +++ b/modules/cas_cache/layer_cache_management.c @@ -2538,20 +2538,27 @@ int cache_mngt_attach_device(const char *cache_name, size_t name_len, result = ocf_mngt_cache_get_by_name(cas_ctx, cache_name, OCF_CACHE_NAME_SIZE, &cache); - if (result) + if (result) { + ocf_volume_destroy(attach_cfg->device.volume); goto err_get; + } result = _cache_mngt_lock_sync(cache); - if (result) + if (result) { + ocf_volume_destroy(attach_cfg->device.volume); goto err_lock; + } result = cache_mngt_check_bdev(&attach_cfg->device, attach_cfg->force, true, cache); - if (result) + if (result) { + ocf_volume_destroy(attach_cfg->device.volume); goto err_ctx; + } context = kzalloc(sizeof(*context), GFP_KERNEL); if (!context) { + ocf_volume_destroy(attach_cfg->device.volume); result = -ENOMEM; goto err_ctx; }