github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace runtime allocation in logger with static percpu buffer

Browse Source 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
This commit is contained in:
Adam Rutkowski 2019-10-18 17:19:08 -04:00
parent d2666b785a
commit dc61d28247
1 changed files with 40 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
modules/cas_cache/context.c
View File

@ -297,6 +297,28 @@ static void _cas_ctx_metadata_updater_stop(ocf_metadata_updater_t mu)
return cas_stop_metadata_updater_thread(mu); return cas_stop_metadata_updater_thread(mu);
} }
#define CAS_LOG_FORMAT_STRING_MAX_LEN 256
static int _cas_ctx_logger_open(ocf_logger_t logger)
{
void __percpu *priv;
priv = alloc_percpu(char[CAS_LOG_FORMAT_STRING_MAX_LEN]);
if (!priv)
return -ENOMEM;
ocf_logger_set_priv(logger, priv);
return 0;
}
static void _cas_ctx_logger_close(ocf_logger_t logger)
{
void __percpu *priv = ocf_logger_get_priv(logger);
free_percpu(priv);
}
/* /*
* *
*/ */
@ -313,17 +335,27 @@ static int _cas_ctx_logger_print(ocf_logger_t logger, ocf_logger_lvl_t lvl,
[log_info] = KERN_INFO, [log_info] = KERN_INFO,
[log_debug] = KERN_DEBUG, [log_debug] = KERN_DEBUG,
}; };
char *format; int ret;
void __percpu *priv;
char *buf;
if (((unsigned)lvl) >= sizeof(level)/sizeof(level[0])) if (((unsigned)lvl) >= sizeof(level)/sizeof(level[0]))
return -EINVAL; return -EINVAL;
format = kasprintf(GFP_ATOMIC, "%s%s", level[lvl], fmt); priv = ocf_logger_get_priv(logger);
if (!format) buf = get_cpu_ptr(priv);
return -ENOMEM;
vprintk(format, args); /* Try to prepend log level prefix to format string. If this fails
* for any reason, we just fall back to user provided format string */
ret = snprintf(buf, CAS_LOG_FORMAT_STRING_MAX_LEN, "%s%s", level[lvl],
fmt);
if (ret >= CAS_LOG_FORMAT_STRING_MAX_LEN)
vprintk(fmt, args);
else
vprintk(buf, args);
kfree(format);
put_cpu_ptr(priv);
return 0; return 0;
} }
@ -381,6 +413,8 @@ static const struct ocf_ctx_config ctx_cfg = {
}, },
.logger = { .logger = {
.open = _cas_ctx_logger_open,
.close = _cas_ctx_logger_close,
.print = _cas_ctx_logger_print, .print = _cas_ctx_logger_print,
.print_rl = _cas_ctx_logger_print_rl, .print_rl = _cas_ctx_logger_print_rl,
.dump_stack = _cas_ctx_logger_dump_stack, .dump_stack = _cas_ctx_logger_dump_stack,