github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #46 from micrakow/cache_stop_dirty_bug_on

Browse Source 
Added check for dirty cache/core during cache stop/core removal
This commit is contained in:
Adam Rutkowski 2019-06-26 05:37:13 -04:00 committed by GitHub
commit e4b603396b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
modules/cas_cache/layer_cache_management.c
View File

@ -713,7 +713,7 @@ int cache_mngt_remove_core_from_cache(struct kcas_remove_core *cmd)
return result; return result;
if (!cmd->force_no_flush) { if (!cmd->force_no_flush) {
/* First check state and flush data (if requested by user) /* First check state and flush data (if requested by user)
under read lock */ under read lock */
result = _cache_mngt_read_lock_sync(cache); result = _cache_mngt_read_lock_sync(cache);
if (result) if (result)
@ -766,6 +766,9 @@ int cache_mngt_remove_core_from_cache(struct kcas_remove_core *cmd)
_cache_mngt_remove_core_complete, &context); _cache_mngt_remove_core_complete, &context);
} }
if (!cmd->force_no_flush && !flush_result)
BUG_ON(ocf_mngt_core_is_dirty(core));
wait_for_completion(&context.compl); wait_for_completion(&context.compl);
if (!result && flush_result) if (!result && flush_result)
@ -1614,6 +1617,9 @@ int cache_mngt_exit_instance(ocf_cache_id_t id, int flush)
if (flush) if (flush)
flush_status = _cache_mngt_cache_flush_sync(cache, false); flush_status = _cache_mngt_cache_flush_sync(cache, false);
if (flush && !flush_status)
BUG_ON(ocf_mngt_cache_is_dirty(cache));
/* Stop cache device */ /* Stop cache device */
status = _cache_mngt_cache_stop_sync(cache); status = _cache_mngt_cache_stop_sync(cache);
if (status && status != -OCF_ERR_WRITE_CACHE) if (status && status != -OCF_ERR_WRITE_CACHE)