From f0a398116cdbfaf0ddad3e15d44aa44a4a9db0da Mon Sep 17 00:00:00 2001 From: Adam Rutkowski Date: Tue, 20 Sep 2022 16:21:12 +0200 Subject: [PATCH] Clarify ALRU wake up time documentation ALRU does not have a configurable sleep time between active awakenings of the cleaning thread. Once it starts cleaning, it does not back off unless staleness time and/or activity threshold constraints force it to do so. Wake up time parameter only controls sleep time after an idle wake up. Updating casadm help and man page accordingly. Signed-off-by: Adam Rutkowski --- casadm/cas_main.c | 2 +- casadm/casadm.8 | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/casadm/cas_main.c b/casadm/cas_main.c index 6d8f8b1..3fae855 100644 --- a/casadm/cas_main.c +++ b/casadm/cas_main.c @@ -740,7 +740,7 @@ static struct cas_param cas_cache_params[] = { #define CLEANING_POLICY_TYPE_DESC "Cleaning policy type. " \ "Available policy types: {nop|alru|acp}" -#define CLEANING_ALRU_WAKE_UP_DESC "Period of time between awakenings of flushing thread <%d-%d>[s] (default: %d s)" +#define CLEANING_ALRU_WAKE_UP_DESC "Cleaning thread sleep time after an idle wake up <%d-%d>[s] (default: %d s)" #define CLEANING_ALRU_STALENESS_TIME_DESC "Time that has to pass from the last write operation before a dirty cache" \ " block can be scheduled to be flushed <%d-%d>[s] (default: %d s)" #define CLEANING_ALRU_FLUSH_MAX_BUFFERS_DESC "Number of dirty cache blocks to be flushed in one cleaning cycle" \ diff --git a/casadm/casadm.8 b/casadm/casadm.8 index 4edffd2..8575906 100644 --- a/casadm/casadm.8 +++ b/casadm/casadm.8 @@ -286,7 +286,9 @@ Identifier of cache instance <1-16384>. .TP .B -w, --wake-up -Period of time between awakenings of flushing thread [s] (default: 20 s). +Cleaning thread sleep time after an idle wake up [s] (default: 20 s). +Idle wake up happens when there is no dirty data or the cleaning thread does not start cleaning +due to staleness time and/or activity threshold constraints. .TP .B -s, --staleness-time