From 5c8f9a0d8f68e350df014acc451fc3a7bcc39290 Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Thu, 24 Mar 2022 10:32:44 +0100 Subject: [PATCH 1/2] casadm: more informative logging on activate Signed-off-by: Michal Mielewczyk --- casadm/cas_lib.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/casadm/cas_lib.c b/casadm/cas_lib.c index c0b53f1..9066d71 100644 --- a/casadm/cas_lib.c +++ b/casadm/cas_lib.c @@ -3033,9 +3033,17 @@ int standby_activate(int cache_id, const char *cache_device) } if (cas_ioctl(KCAS_IOCTL_STANDBY_ACTIVATE, &cmd) != SUCCESS) { - print_err(cmd.ext_err_code ? : KCAS_ERR_SYSTEM); + if (abs(cmd.ext_err_code) == OCF_ERR_NOT_OPEN_EXC) { + cas_printf(LOG_ERR, "Cannot open the device exclusively. Make sure " + "to detach cache before activation.\n"); + } else { + print_err(cmd.ext_err_code ? : KCAS_ERR_SYSTEM); + } return FAILURE; } + cas_printf(LOG_INFO, "Successfully activated cache instance %hu\n", + cache_id); + return SUCCESS; } From c11e80d085c4eb9f1e017352ef2fe61203ba2259 Mon Sep 17 00:00:00 2001 From: Michal Mielewczyk Date: Thu, 24 Mar 2022 10:45:10 +0100 Subject: [PATCH 2/2] casadm: more informative logging on standby detach Signed-off-by: Michal Mielewczyk --- casadm/cas_lib.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/casadm/cas_lib.c b/casadm/cas_lib.c index 9066d71..c02046d 100644 --- a/casadm/cas_lib.c +++ b/casadm/cas_lib.c @@ -3018,7 +3018,15 @@ int standby_detach(int cache_id) .cache_id = cache_id }; - return cas_ioctl(KCAS_IOCTL_STANDBY_DETACH, &cmd); + if (cas_ioctl(KCAS_IOCTL_STANDBY_DETACH, &cmd) != SUCCESS) { + print_err(cmd.ext_err_code ? : KCAS_ERR_SYSTEM); + return FAILURE; + } + + cas_printf(LOG_INFO, "Successfully detached cache instance %hu\n", + cache_id); + + return SUCCESS; } int standby_activate(int cache_id, const char *cache_device)