github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable cache attach and detach

Browse Source 
The feature is disable due to a possible data corruption which may occur when
attaching a new caching device. Once the problem is resolved this commit should
be reverted

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
This commit is contained in:
Michal Mielewczyk 2024-09-26 16:34:07 +02:00
parent cefa6ab121
commit f34328adf2
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
casadm/cas_main.c
View File

@ -2237,7 +2237,7 @@ static cli_command cas_commands[] = {
.options = attach_cache_options, .options = attach_cache_options,
.command_handle_opts = start_cache_command_handle_option, .command_handle_opts = start_cache_command_handle_option,
.handle = handle_cache_attach, .handle = handle_cache_attach,
.flags = CLI_SU_REQUIRED, .flags = (CLI_SU_REQUIRED | CLI_COMMAND_BLOCKED),
.help = NULL, .help = NULL,
}, },
{ {
@ -2247,7 +2247,7 @@ static cli_command cas_commands[] = {
.options = detach_options, .options = detach_options,
.command_handle_opts = command_handle_option, .command_handle_opts = command_handle_option,
.handle = handle_cache_detach, .handle = handle_cache_detach,
.flags = CLI_SU_REQUIRED, .flags = (CLI_SU_REQUIRED | CLI_COMMAND_BLOCKED),
.help = NULL, .help = NULL,
}, },
{ {

7
modules/cas_cache/service_ui_ioctl.c
View File

@ -86,6 +86,10 @@ long cas_service_ioctl_ctrl(struct file *filp, unsigned int cmd,
GET_CMD_INFO(cmd_info, arg); GET_CMD_INFO(cmd_info, arg);
printk(KERN_ERR "Cache attach is not supported!\n");
retval = -ENOTSUP;
RETURN_CMD_RESULT(cmd_info, arg, retval);
cache_name_from_id(cache_name, cmd_info->cache_id); cache_name_from_id(cache_name, cmd_info->cache_id);
retval = cache_mngt_attach_cache_cfg(cache_name, OCF_CACHE_NAME_SIZE, retval = cache_mngt_attach_cache_cfg(cache_name, OCF_CACHE_NAME_SIZE,
@ -104,6 +108,9 @@ long cas_service_ioctl_ctrl(struct file *filp, unsigned int cmd,
char cache_name[OCF_CACHE_NAME_SIZE]; char cache_name[OCF_CACHE_NAME_SIZE];
GET_CMD_INFO(cmd_info, arg); GET_CMD_INFO(cmd_info, arg);
printk(KERN_ERR "Cache detach is not supported!\n");
retval = -ENOTSUP;
RETURN_CMD_RESULT(cmd_info, arg, retval);
cache_name_from_id(cache_name, cmd_info->cache_id); cache_name_from_id(cache_name, cmd_info->cache_id);