github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

casadm: don't cast a float to an int explicitly

Browse Source 
If an underflowed float number was casted to an int explicitly, it's value was
rounded to a lower value.

Using `round()` function ensures that the number will be always rounded to a
nearest integer.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2021-01-29 09:25:16 -05:00
parent c00dc77d0e
commit ffaaaa0a34
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
casadm/Makefile
View File

@ -83,7 +83,7 @@ CFLAGS += -Wall -Werror -z relro -z now -fstack-protector -fPIC -Wformat -Wfo
# #
# Flags for linking # Flags for linking
# #
LDFLAGS = -z noexecstack -z relro -z now -pie -pthread LDFLAGS = -z noexecstack -z relro -z now -pie -pthread -lm
# #
# Targets # Targets
# #

3
casadm/cas_lib.c
View File

@ -38,6 +38,7 @@
#include "psort.h" #include "psort.h"
#include <libgen.h> #include <libgen.h>
#include <regex.h> #include <regex.h>
#include <math.h>
#define PRINT_STAT(x) header->cmd_input.cache_stats.x #define PRINT_STAT(x) header->cmd_input.cache_stats.x
@ -2212,7 +2213,7 @@ static int calculate_max_allocation(uint16_t cache_id, const char *allocation,
if (allocation + strnlen(allocation, MAX_STR_LEN) != end) if (allocation + strnlen(allocation, MAX_STR_LEN) != end)
return FAILURE; return FAILURE;
*part_size = (uint32_t)(alloc * 100); *part_size = (uint32_t)round(alloc * 100);
return SUCCESS; return SUCCESS;
} }