github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #809 from mmichal10/fix-trim-test

Browse Source 
tests: pass through metadata in trim test
This commit is contained in:
Michał Mielewczyk 2021-04-29 03:01:18 -04:00 committed by GitHub
commit ffc9c83fbf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 31 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
test/functional/tests/io/trim/test_trim_eviction.py
View File

@ -5,11 +5,11 @@
import os import os
import pytest import pytest
from api.cas import casadm from api.cas import casadm, ioclass_config
from api.cas.cache_config import CacheMode, CacheLineSize, CleaningPolicy from api.cas.cache_config import CacheMode, CacheLineSize, CleaningPolicy
from core.test_run import TestRun from core.test_run import TestRun
from storage_devices.disk import DiskTypeSet, DiskType, DiskTypeLowerThan from storage_devices.disk import DiskTypeSet, DiskType, DiskTypeLowerThan
from test_tools import fs_utils from test_tools import fs_utils, disk_utils
from test_tools.ddrescue import Ddrescue from test_tools.ddrescue import Ddrescue
from test_tools.disk_utils import Filesystem from test_tools.disk_utils import Filesystem
from test_utils import os_utils from test_utils import os_utils
@ -44,6 +44,8 @@ def test_trim_eviction(cache_mode, cache_line_size, filesystem, cleaning):
core_disk.create_partitions([Size(1, Unit.GibiByte)]) core_disk.create_partitions([Size(1, Unit.GibiByte)])
core_dev = core_disk.partitions[0] core_dev = core_disk.partitions[0]
cache_block_size = disk_utils.get_block_size(cache_disk)
with TestRun.step("Start cache on device supporting trim and add core."): with TestRun.step("Start cache on device supporting trim and add core."):
cache = casadm.start_cache(cache_dev, cache_mode, cache_line_size) cache = casadm.start_cache(cache_dev, cache_mode, cache_line_size)
cache.set_cleaning_policy(cleaning) cache.set_cleaning_policy(cleaning)
@ -54,12 +56,25 @@ def test_trim_eviction(cache_mode, cache_line_size, filesystem, cleaning):
core.create_filesystem(filesystem) core.create_filesystem(filesystem)
core.mount(mount_point, ["discard"]) core.mount(mount_point, ["discard"])
with TestRun.step("Create ioclass config."):
ioclass_config.create_ioclass_config()
ioclass_config.add_ioclass(
ioclass_id=1, eviction_priority=1, allocation="0.00", rule=f"metadata"
)
casadm.load_io_classes(
cache_id=cache.cache_id, file=ioclass_config.default_config_file_path
)
with TestRun.step("Create random file using ddrescue."): with TestRun.step("Create random file using ddrescue."):
test_file = fs_utils.create_random_test_file(test_file_path, core_dev.size * 0.9) test_file = fs_utils.create_random_test_file(test_file_path, core_dev.size * 0.9)
create_file_with_ddrescue(core_dev, test_file) create_file_with_ddrescue(core_dev, test_file)
os_utils.sync()
os_utils.drop_caches()
with TestRun.step("Remove file and create a new one."): with TestRun.step("Remove file and create a new one."):
cache_iostats_before = cache_dev.get_io_stats() cache_iostats_before = cache_dev.get_io_stats()
data_reads_before = cache.get_io_class_statistics(io_class_id=0).block_stats.cache.reads
metadata_reads_before = cache.get_io_class_statistics(io_class_id=1).block_stats.cache.reads
test_file.remove() test_file.remove()
os_utils.sync() os_utils.sync()
os_utils.drop_caches() os_utils.drop_caches()
@ -67,12 +82,23 @@ def test_trim_eviction(cache_mode, cache_line_size, filesystem, cleaning):
with TestRun.step("Check using iostat that reads from cache did not occur."): with TestRun.step("Check using iostat that reads from cache did not occur."):
cache_iostats_after = cache_dev.get_io_stats() cache_iostats_after = cache_dev.get_io_stats()
data_reads_after = cache.get_io_class_statistics(io_class_id=0).block_stats.cache.reads
metadata_reads_after = cache.get_io_class_statistics(io_class_id=1).block_stats.cache.reads
reads_before = cache_iostats_before.sectors_read reads_before = cache_iostats_before.sectors_read
reads_after = cache_iostats_after.sectors_read reads_after = cache_iostats_after.sectors_read
if reads_after != reads_before: metadata_reads_diff = metadata_reads_after - metadata_reads_before
TestRun.fail(f"Number of reads from cache before and after removing test file " data_reads_diff = data_reads_after - data_reads_before
f"differs. Reads before: {reads_before}, reads after: {reads_after}.") iostat_diff = (reads_after - reads_before) * cache_block_size
if iostat_diff > int(metadata_reads_diff) or int(data_reads_diff) > 0:
TestRun.fail(
f"Number of reads from cache before and after removing test file "
f"differs. Sectors read before: {reads_before}, sectors read after: {reads_after}."
f"Data read from cache before {data_reads_before}, after {data_reads_after}."
f"Metadata read from cache before {metadata_reads_before}, "
f"after {metadata_reads_after}."
)
else: else:
TestRun.LOGGER.info( TestRun.LOGGER.info(
"Number of reads from cache before and after removing test file is the same.") "Number of reads from cache before and after removing test file is the same.")