From 12e47f68f509fd09d53e86079265b4664c546959 Mon Sep 17 00:00:00 2001
From: Fine <fanxue0830@gmail.com>
Date: Wed, 2 Nov 2022 17:38:10 +0800
Subject: [PATCH] refactor legend config

---
 .../widget/graph-styles/Area.vue              |   2 +
 .../configuration/widget/graph-styles/Bar.vue |   2 +
 .../widget/graph-styles/Line.vue              | 104 +-------------
 .../widget/graph-styles/components/Legend.vue | 133 ++++++++++++++++++
 4 files changed, 140 insertions(+), 101 deletions(-)
 create mode 100644 src/views/dashboard/configuration/widget/graph-styles/components/Legend.vue

diff --git a/src/views/dashboard/configuration/widget/graph-styles/Area.vue b/src/views/dashboard/configuration/widget/graph-styles/Area.vue
index 9c4b3e0b..620c803b 100644
--- a/src/views/dashboard/configuration/widget/graph-styles/Area.vue
+++ b/src/views/dashboard/configuration/widget/graph-styles/Area.vue
@@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. -->
 <template>
+  <Legend />
   <div>
     <span class="label">{{ t("areaOpacity") }}</span>
     <el-slider
@@ -31,6 +32,7 @@ limitations under the License. -->
 import { ref } from "vue";
 import { useI18n } from "vue-i18n";
 import { useDashboardStore } from "@/store/modules/dashboard";
+import Legend from "./components/Legend.vue";
 
 const { t } = useI18n();
 const dashboardStore = useDashboardStore();
diff --git a/src/views/dashboard/configuration/widget/graph-styles/Bar.vue b/src/views/dashboard/configuration/widget/graph-styles/Bar.vue
index 0cffd9e3..e5268472 100644
--- a/src/views/dashboard/configuration/widget/graph-styles/Bar.vue
+++ b/src/views/dashboard/configuration/widget/graph-styles/Bar.vue
@@ -13,6 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. -->
 <template>
+  <Legend />
   <div>
     <span class="label">{{ t("showBackground") }}</span>
     <el-switch
@@ -27,6 +28,7 @@ limitations under the License. -->
 import { ref } from "vue";
 import { useDashboardStore } from "@/store/modules/dashboard";
 import { useI18n } from "vue-i18n";
+import Legend from "./components/Legend.vue";
 
 const { t } = useI18n();
 const dashboardStore = useDashboardStore();
diff --git a/src/views/dashboard/configuration/widget/graph-styles/Line.vue b/src/views/dashboard/configuration/widget/graph-styles/Line.vue
index 65f1b973..de057260 100644
--- a/src/views/dashboard/configuration/widget/graph-styles/Line.vue
+++ b/src/views/dashboard/configuration/widget/graph-styles/Line.vue
@@ -13,71 +13,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. -->
 <template>
-  <div>
-    <span class="label">{{ t("showLegend") }}</span>
-    <el-switch
-      v-model="legend.showLegend"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ showLegend: legend.showLegend })"
-    />
-  </div>
-  <div>
-    <span class="label">{{ t("legendOptions") }}</span>
-    <span class="title mr-5">{{ t("asTable") }}</span>
-    <el-switch
-      v-model="legend.asTable"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ asTable: legend.asTable })"
-    />
-    <span class="title ml-20 mr-5">{{ t("toTheRight") }}</span>
-    <el-switch
-      v-model="legend.toTheRight"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ toTheRight: legend.toTheRight })"
-    />
-    <span class="title ml-20 mr-5">{{ t("width") }}</span>
-    <el-input
-      v-model="legend.width"
-      class="inputs"
-      size="small"
-      placeholder="Please input the width"
-      @change="updateLegendConfig({ width: legend.width })"
-    />
-  </div>
-  <div>
-    <span class="label">{{ t("legendValues") }}</span>
-    <span class="title mr-5">{{ t("min") }}</span>
-    <el-switch
-      v-model="legend.min"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ min: legend.min })"
-    />
-    <span class="title ml-20 mr-5">{{ t("max") }}</span>
-    <el-switch
-      v-model="legend.max"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ max: legend.max })"
-    />
-    <span class="title ml-20 mr-5">{{ t("mean") }}</span>
-    <el-switch
-      v-model="legend.mean"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ mean: legend.mean })"
-    />
-    <span class="title ml-20 mr-5">{{ t("total") }}</span>
-    <el-switch
-      v-model="legend.total"
-      active-text="Yes"
-      inactive-text="No"
-      @change="updateLegendConfig({ total: legend.total })"
-    />
-  </div>
+  <Legend />
   <div>
     <span class="label">{{ t("showXAxis") }}</span>
     <el-switch
@@ -125,10 +61,10 @@ limitations under the License. -->
   </div>
 </template>
 <script lang="ts" setup>
-import { ref, computed, reactive } from "vue";
+import { ref, computed } from "vue";
 import { useI18n } from "vue-i18n";
 import { useDashboardStore } from "@/store/modules/dashboard";
-import { LegendOptions } from "@/types/dashboard";
+import Legend from "./components/Legend.vue";
 
 const { t } = useI18n();
 const dashboardStore = useDashboardStore();
@@ -136,17 +72,6 @@ const graph = computed(() => dashboardStore.selectedGrid.graph || {});
 const smooth = ref(graph.value.smooth);
 const showSymbol = ref(graph.value.showSymbol);
 const step = ref(graph.value.step);
-const legend = reactive<LegendOptions>({
-  showLegend: true,
-  total: false,
-  min: false,
-  max: false,
-  mean: false,
-  asTable: false,
-  toTheRight: false,
-  width: 120,
-  ...graph.value.legend,
-});
 
 function updateConfig(param: { [key: string]: unknown }) {
   const graph = {
@@ -155,17 +80,6 @@ function updateConfig(param: { [key: string]: unknown }) {
   };
   dashboardStore.selectWidget({ ...dashboardStore.selectedGrid, graph });
 }
-
-function updateLegendConfig(param: { [key: string]: unknown }) {
-  const g = {
-    ...dashboardStore.selectedGrid.graph,
-    legend: {
-      ...dashboardStore.selectedGrid.graph.legend,
-      ...param,
-    },
-  };
-  dashboardStore.selectWidget({ ...dashboardStore.selectedGrid, g });
-}
 </script>
 <style lang="scss" scoped>
 .label {
@@ -174,16 +88,4 @@ function updateLegendConfig(param: { [key: string]: unknown }) {
   margin-top: 5px;
   margin-bottom: -5px;
 }
-
-.title {
-  font-size: 12px;
-  display: inline-flex;
-  height: 32px;
-  line-height: 34px;
-  vertical-align: middle;
-}
-
-.inputs {
-  width: 120px;
-}
 </style>
diff --git a/src/views/dashboard/configuration/widget/graph-styles/components/Legend.vue b/src/views/dashboard/configuration/widget/graph-styles/components/Legend.vue
new file mode 100644
index 00000000..71f33fac
--- /dev/null
+++ b/src/views/dashboard/configuration/widget/graph-styles/components/Legend.vue
@@ -0,0 +1,133 @@
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License. -->
+<template>
+  <div>
+    <span class="label">{{ t("showLegend") }}</span>
+    <el-switch
+      v-model="legend.showLegend"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ showLegend: legend.showLegend })"
+    />
+  </div>
+  <div>
+    <span class="label">{{ t("legendOptions") }}</span>
+    <span class="title mr-5">{{ t("asTable") }}</span>
+    <el-switch
+      v-model="legend.asTable"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ asTable: legend.asTable })"
+    />
+    <span class="title ml-20 mr-5">{{ t("toTheRight") }}</span>
+    <el-switch
+      v-model="legend.toTheRight"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ toTheRight: legend.toTheRight })"
+    />
+    <span class="title ml-20 mr-5">{{ t("width") }}</span>
+    <el-input
+      v-model="legend.width"
+      class="inputs"
+      size="small"
+      placeholder="Please input the width"
+      @change="updateLegendConfig({ width: legend.width })"
+    />
+  </div>
+  <div>
+    <span class="label">{{ t("legendValues") }}</span>
+    <span class="title mr-5">{{ t("min") }}</span>
+    <el-switch
+      v-model="legend.min"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ min: legend.min })"
+    />
+    <span class="title ml-20 mr-5">{{ t("max") }}</span>
+    <el-switch
+      v-model="legend.max"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ max: legend.max })"
+    />
+    <span class="title ml-20 mr-5">{{ t("mean") }}</span>
+    <el-switch
+      v-model="legend.mean"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ mean: legend.mean })"
+    />
+    <span class="title ml-20 mr-5">{{ t("total") }}</span>
+    <el-switch
+      v-model="legend.total"
+      active-text="Yes"
+      inactive-text="No"
+      @change="updateLegendConfig({ total: legend.total })"
+    />
+  </div>
+</template>
+<script lang="ts" setup>
+import { computed, reactive } from "vue";
+import { useI18n } from "vue-i18n";
+import { useDashboardStore } from "@/store/modules/dashboard";
+import { LegendOptions } from "@/types/dashboard";
+
+const { t } = useI18n();
+const dashboardStore = useDashboardStore();
+const graph = computed(() => dashboardStore.selectedGrid.graph || {});
+const legend = reactive<LegendOptions>({
+  showLegend: true,
+  total: false,
+  min: false,
+  max: false,
+  mean: false,
+  asTable: false,
+  toTheRight: false,
+  width: 120,
+  ...graph.value.legend,
+});
+
+function updateLegendConfig(param: { [key: string]: unknown }) {
+  const g = {
+    ...dashboardStore.selectedGrid.graph,
+    legend: {
+      ...dashboardStore.selectedGrid.graph.legend,
+      ...param,
+    },
+  };
+  dashboardStore.selectWidget({ ...dashboardStore.selectedGrid, g });
+}
+</script>
+<style lang="scss" scoped>
+.label {
+  font-size: 13px;
+  display: block;
+  margin-top: 5px;
+  margin-bottom: -5px;
+}
+
+.title {
+  font-size: 12px;
+  display: inline-flex;
+  height: 32px;
+  line-height: 34px;
+  vertical-align: middle;
+}
+
+.inputs {
+  width: 120px;
+}
+</style>