From cc367dd29cad54f39a06fcc777d0febe7fbd2033 Mon Sep 17 00:00:00 2001
From: Fine0830 <fanxue0830@gmail.com>
Date: Wed, 21 Jun 2023 18:08:47 +0800
Subject: [PATCH 1/2] fix: add a link to explain the expression metric, add
 units in the continue profiling widget (#288)

---
 .../configuration/widget/metric/Index.vue     | 28 +++++++++++++------
 .../components/Policy.vue                     | 10 +++++--
 src/views/dashboard/related/log/Header.vue    |  4 +--
 3 files changed, 30 insertions(+), 12 deletions(-)

diff --git a/src/views/dashboard/configuration/widget/metric/Index.vue b/src/views/dashboard/configuration/widget/metric/Index.vue
index 9a6e486b..d7c34533 100644
--- a/src/views/dashboard/configuration/widget/metric/Index.vue
+++ b/src/views/dashboard/configuration/widget/metric/Index.vue
@@ -26,14 +26,21 @@ limitations under the License. -->
     />
   </div>
   <div>{{ t("metrics") }}</div>
-  <el-switch
-    v-model="isExpression"
-    class="mb-5"
-    active-text="Expressions"
-    inactive-text="General"
-    size="small"
-    @change="changeMetricMode"
-  />
+  <div class="flex-h">
+    <el-switch
+      v-model="isExpression"
+      class="mb-5"
+      active-text="Expressions"
+      inactive-text="General"
+      size="small"
+      @change="changeMetricMode"
+    />
+    <div class="ml-5 link">
+      <a target="_blank" href="https://skywalking.apache.org/docs/main/next/en/api/metrics-query-expression/">
+        <Icon iconName="info_outline" size="middle" />
+      </a>
+    </div>
+  </div>
   <div v-if="isExpression && states.isList">
     <span class="title">{{ t("summary") }}</span>
     <span>{{ t("detail") }}</span>
@@ -641,4 +648,9 @@ limitations under the License. -->
     display: inline-block;
     width: 410px;
   }
+
+  .link {
+    cursor: pointer;
+    color: #409eff;
+  }
 </style>
diff --git a/src/views/dashboard/related/continuous-profiling/components/Policy.vue b/src/views/dashboard/related/continuous-profiling/components/Policy.vue
index 231cedc6..933b1c33 100644
--- a/src/views/dashboard/related/continuous-profiling/components/Policy.vue
+++ b/src/views/dashboard/related/continuous-profiling/components/Policy.vue
@@ -68,11 +68,17 @@ limitations under the License. -->
     </div>
     <div>
       <div class="label">{{ t("count") }}</div>
-      <el-input-number size="small" class="profile-input" :min="0" v-model="item.count" @change="changeParam" />
+      <div class="flex-h">
+        <el-input-number size="small" class="profile-input" :min="0" v-model="item.count" @change="changeParam" />
+        <span class="ml-5">s</span>
+      </div>
     </div>
     <div>
       <div class="label">{{ t("period") }}</div>
-      <el-input-number size="small" class="profile-input" :min="0" v-model="item.period" @change="changeParam" />
+      <div class="flex-h">
+        <el-input-number size="small" class="profile-input" :min="0" v-model="item.period" @change="changeParam" />
+        <span class="ml-5">s</span>
+      </div>
     </div>
     <div v-show="TYPES.includes(item.type)">
       <div class="label">{{ t("uriRegex") }}</div>
diff --git a/src/views/dashboard/related/log/Header.vue b/src/views/dashboard/related/log/Header.vue
index eb3a6a47..3520802d 100644
--- a/src/views/dashboard/related/log/Header.vue
+++ b/src/views/dashboard/related/log/Header.vue
@@ -107,8 +107,8 @@ limitations under the License. -->
         @change="addLabels('excludingKeywordsOfContent')"
       />
       <el-tooltip :content="t('keywordsOfContentLogTips')">
-        <span class="log-tips" v-show="!logStore.supportQueryLogsByKeywords">
-          <Icon icon="help" class="mr-5" />
+        <span v-show="!logStore.supportQueryLogsByKeywords">
+          <Icon iconName="help" class="mr-5" />
         </span>
       </el-tooltip>
     </div>

From 63db3fbc2e3843d38f9b5b6e4b8666066da4d517 Mon Sep 17 00:00:00 2001
From: Fine0830 <fanxue0830@gmail.com>
Date: Sun, 25 Jun 2023 22:41:45 +0800
Subject: [PATCH 2/2] fix: update the title of instance list and notices in the
 continue profiling (#289)

---
 src/locales/lang/en.ts                                        | 2 +-
 .../related/continuous-profiling/components/Policy.vue        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/locales/lang/en.ts b/src/locales/lang/en.ts
index 6bc4cacf..7dbf950c 100644
--- a/src/locales/lang/en.ts
+++ b/src/locales/lang/en.ts
@@ -399,7 +399,7 @@ const msg = {
   uriRegex: "URI Regex",
   uriList: "URI List",
   processes: "Processes",
-  monitorInstances: "Monitor Instances",
+  monitorInstances: "Monitoring Instances",
   processDashboards: "Process Dashboards",
   instanceDashboards: "Instance Dashboards",
   detailLabel: "Detail Label",
diff --git a/src/views/dashboard/related/continuous-profiling/components/Policy.vue b/src/views/dashboard/related/continuous-profiling/components/Policy.vue
index 933b1c33..09ecc35d 100644
--- a/src/views/dashboard/related/continuous-profiling/components/Policy.vue
+++ b/src/views/dashboard/related/continuous-profiling/components/Policy.vue
@@ -56,7 +56,7 @@ limitations under the License. -->
     <div>
       <div class="label">
         <span class="mr-5">{{ t("threshold") }}</span>
-        <span>({{ getNotice(item.type) }} )</span>
+        <span>{{ getNotice(item.type) }}</span>
       </div>
       <el-input
         type="number"
@@ -202,7 +202,7 @@ limitations under the License. -->
       HTTP_AVG_RESPONSE_TIME: "It is a response time in milliseconds",
     };
 
-    return map[type];
+    return map[type] ? `(${map[type]})` : "";
   }
 </script>
 <style lang="scss" scoped>