From 655c4c41e9293001e2c438fb2c02725fa0c1043f Mon Sep 17 00:00:00 2001
From: Qiuxia Fan <fine0830@outlook.com>
Date: Mon, 24 Jan 2022 21:19:57 +0800
Subject: [PATCH] refactor: update MetricOptions

---
 src/graph/fragments/selector.ts               |   3 +-
 src/hooks/useProcessor.ts                     |   2 +-
 src/locales/lang/en.ts                        |   5 +-
 src/locales/lang/zh.ts                        |   3 +-
 .../dashboard/configuration/ConfigEdit.vue    |  76 +----------
 .../dashboard/configuration/MetricOptions.vue | 127 ++++++++++++++----
 src/views/dashboard/data.ts                   |  20 +--
 src/views/dashboard/graphs/EndpointList.vue   |  12 +-
 src/views/dashboard/graphs/InstanceList.vue   |  11 +-
 src/views/dashboard/graphs/ServiceList.vue    |  12 +-
 src/views/dashboard/panel/Tool.vue            |   5 +-
 11 files changed, 137 insertions(+), 139 deletions(-)

diff --git a/src/graph/fragments/selector.ts b/src/graph/fragments/selector.ts
index ada13af2..4b90d4f9 100644
--- a/src/graph/fragments/selector.ts
+++ b/src/graph/fragments/selector.ts
@@ -93,7 +93,7 @@ export const getInstance = {
 };
 
 export const getEndpoint = {
-  variable: "$endpointId: String!",
+  variable: "$endpointId: ID!",
   query: `
   endpoint: getEndpointInfo(endpointId: $endpointId) {
     id
@@ -101,7 +101,6 @@ export const getEndpoint = {
       label: name
       serviceId
       serviceName
-    }
   }
   `,
 };
diff --git a/src/hooks/useProcessor.ts b/src/hooks/useProcessor.ts
index 5663f24d..c885373b 100644
--- a/src/hooks/useProcessor.ts
+++ b/src/hooks/useProcessor.ts
@@ -22,7 +22,7 @@ import { useAppStoreWithOut } from "@/store/modules/app";
 import { Instance, Endpoint } from "@/types/selector";
 
 export function useQueryProcessor(config: any) {
-  if (!(config.metrics && config.metrics.length)) {
+  if (!(config.metrics && config.metrics[0])) {
     return;
   }
   const appStore = useAppStoreWithOut();
diff --git a/src/locales/lang/en.ts b/src/locales/lang/en.ts
index a57b3d19..e7b840fa 100644
--- a/src/locales/lang/en.ts
+++ b/src/locales/lang/en.ts
@@ -30,7 +30,7 @@ const msg = {
   events: "Events",
   alerts: "Alerts",
   settings: "Settings",
-  dashboards: "Dashboards",
+  dashboards: "Dashboard",
   profiles: "Profiles",
   database: "Database",
   serviceName: "Service Name",
@@ -53,7 +53,8 @@ const msg = {
   instance: "Instance",
   create: "Create",
   loading: "Loading",
-  selectVisualization: "Select your visualization",
+  selectVisualization: "Visualize your metrics",
+  visualization: "Visualization",
   graphStyles: "Graph styles",
   widgetOptions: "Widget options",
   standardOptions: "Standard options",
diff --git a/src/locales/lang/zh.ts b/src/locales/lang/zh.ts
index d2a2a7a5..42137a22 100644
--- a/src/locales/lang/zh.ts
+++ b/src/locales/lang/zh.ts
@@ -51,7 +51,8 @@ const msg = {
   endpoint: "端点",
   create: "新建",
   loading: "加载中",
-  selectVisualization: "选择你的可视化",
+  selectVisualization: "可视化指标",
+  visualization: "可视化",
   graphStyles: "图形样式",
   widgetOptions: "组件选项",
   standardOptions: "标准选项",
diff --git a/src/views/dashboard/configuration/ConfigEdit.vue b/src/views/dashboard/configuration/ConfigEdit.vue
index 579941b3..0ae6fdea 100644
--- a/src/views/dashboard/configuration/ConfigEdit.vue
+++ b/src/views/dashboard/configuration/ConfigEdit.vue
@@ -40,30 +40,16 @@ limitations under the License. -->
         v-model="states.activeNames"
         :style="{ '--el-collapse-header-font-size': '15px' }"
       >
-        <el-collapse-item :title="t('metricName')" name="1">
+        <el-collapse-item :title="t('selectVisualization')" name="1">
           <MetricOptions @update="getSource" @loading="setLoading" />
         </el-collapse-item>
-        <el-collapse-item :title="t('selectVisualization')" name="2">
-          <div class="chart-types">
-            <span
-              v-for="(type, index) in states.visType"
-              :key="index"
-              @click="changeChartType(type)"
-              :class="{
-                active: type.value === dashboardStore.selectedGrid.graph.type,
-              }"
-            >
-              {{ type.label }}
-            </span>
-          </div>
-        </el-collapse-item>
-        <el-collapse-item :title="t('graphStyles')" name="3">
+        <el-collapse-item :title="t('graphStyles')" name="2">
           <component :is="`${dashboardStore.selectedGrid.graph.type}Config`" />
         </el-collapse-item>
-        <el-collapse-item :title="t('widgetOptions')" name="4">
+        <el-collapse-item :title="t('widgetOptions')" name="3">
           <WidgetOptions />
         </el-collapse-item>
-        <el-collapse-item :title="t('standardOptions')" name="5">
+        <el-collapse-item :title="t('standardOptions')" name="4">
           <StandardOptions />
         </el-collapse-item>
       </el-collapse>
@@ -83,13 +69,6 @@ import { reactive, defineComponent, ref } from "vue";
 import { useI18n } from "vue-i18n";
 import { useDashboardStore } from "@/store/modules/dashboard";
 import { useAppStoreWithOut } from "@/store/modules/app";
-import {
-  ChartTypes,
-  DefaultGraphConfig,
-  PodsChartTypes,
-  TableChartTypes,
-  EntityType,
-} from "../data";
 import { Option } from "@/types/app";
 import graphs from "../graphs";
 import configs from "./graph-styles";
@@ -117,37 +96,12 @@ export default defineComponent({
       source: any;
       index: string;
       visType: Option[];
-      isTable: boolean;
     }>({
       activeNames: "1",
       source: {},
       index: dashboardStore.selectedGrid.i,
       visType: [],
-      isTable: false,
     });
-    states.isTable = TableChartTypes.includes(
-      dashboardStore.selectedGrid.graph.type || ""
-    );
-
-    if (dashboardStore.entity === EntityType[0].value) {
-      states.visType = ChartTypes.filter(
-        (d: Option) => d.value !== "serviceList"
-      );
-    } else if (dashboardStore.entity === EntityType[1].value) {
-      states.visType = ChartTypes.filter(
-        (d: Option) => !PodsChartTypes.includes(d.value)
-      );
-    } else {
-      states.visType = ChartTypes.filter(
-        (d: Option) => !TableChartTypes.includes(d.value)
-      );
-    }
-
-    function changeChartType(item: Option) {
-      const graph = DefaultGraphConfig[item.value];
-      states.isTable = TableChartTypes.includes(graph.type);
-      dashboardStore.selectWidget({ ...dashboardStore.selectedGrid, graph });
-    }
 
     function getSource(source: unknown) {
       states.source = source;
@@ -160,12 +114,12 @@ export default defineComponent({
     function applyConfig() {
       dashboardStore.setConfigs(dashboardStore.selectedGrid);
       dashboardStore.setConfigPanel(false);
+      dashboardStore.selectWidget(null);
     }
 
     return {
       states,
       loading,
-      changeChartType,
       t,
       appStoreWithOut,
       configHeight,
@@ -226,32 +180,12 @@ export default defineComponent({
   min-width: 1280px;
 }
 
-.chart-types {
-  span {
-    display: inline-block;
-    padding: 5px 10px;
-    border: 1px solid #ccc;
-    background-color: #fff;
-    border-right: 0;
-    cursor: pointer;
-  }
-
-  span:nth-last-child(1) {
-    border-right: 1px solid #ccc;
-  }
-}
-
 .no-data {
   font-size: 14px;
   text-align: center;
   line-height: 400px;
 }
 
-span.active {
-  background-color: #409eff;
-  color: #fff;
-}
-
 .footer {
   position: fixed;
   bottom: 0;
diff --git a/src/views/dashboard/configuration/MetricOptions.vue b/src/views/dashboard/configuration/MetricOptions.vue
index b60cdcd8..7473fc4d 100644
--- a/src/views/dashboard/configuration/MetricOptions.vue
+++ b/src/views/dashboard/configuration/MetricOptions.vue
@@ -14,17 +14,15 @@ See the License for the specific language governing permissions and
 limitations under the License. -->
 <template>
   <div v-show="states.isTable" class="ds-name">
-    <div>Dashboard</div>
-    <Selector
-      :value="dashboardStore.selectedGrid.graph.dashboardName"
-      :options="states.metricList"
-      size="mini"
-      placeholder="Select a dashboard"
+    <div>{{ t("dashboards") }}</div>
+    <el-input
+      v-model="states.dashboardName"
+      placeholder="Please input dashboard name"
       @change="changeDashboard"
       class="selectors"
     />
   </div>
-  <div>Metrics</div>
+  <div>{{ t("metrics") }}</div>
   <div
     v-for="(metric, index) in states.metrics"
     :key="index"
@@ -69,17 +67,40 @@ limitations under the License. -->
       />
     </span>
   </div>
+  <div>{{ t("visualization") }}</div>
+  <div class="chart-types">
+    <span
+      v-for="(type, index) in states.visTypes"
+      :key="index"
+      @click="changeChartType(type)"
+      :class="{
+        active: type.value === dashboardStore.selectedGrid.graph.type,
+      }"
+    >
+      {{ type.label }}
+    </span>
+  </div>
 </template>
 <script lang="ts" setup>
-import { reactive, watch } from "vue";
+import { reactive } from "vue";
 import { Option } from "@/types/app";
 import { useDashboardStore } from "@/store/modules/dashboard";
-import { MetricTypes, TableChartTypes, MetricCatalog } from "../data";
+import {
+  MetricTypes,
+  TableChartTypes,
+  MetricCatalog,
+  DefaultGraphConfig,
+  EntityType,
+  ChartTypes,
+  PodsChartTypes,
+} from "../data";
 import { ElMessage } from "element-plus";
 import Icon from "@/components/Icon.vue";
 import { useQueryProcessor, useSourceProcessor } from "@/hooks/useProcessor";
+import { useI18n } from "vue-i18n";
 
 /*global defineEmits */
+const { t } = useI18n();
 const emit = defineEmits(["update", "loading"]);
 const dashboardStore = useDashboardStore();
 const { metrics, metricTypes, graph } = dashboardStore.selectedGrid;
@@ -87,19 +108,22 @@ const states = reactive<{
   metrics: string[];
   metricTypes: string[];
   metricTypeList: Option[][];
-  visType: Option[];
+  visTypes: Option[];
   isTable: boolean;
   metricList: (Option & { type: string })[];
+  dashboardName: string;
 }>({
   metrics: metrics && metrics.length ? metrics : [""],
   metricTypes: metricTypes && metricTypes.length ? metricTypes : [""],
   metricTypeList: [],
-  visType: [],
+  visTypes: [],
   isTable: false,
   metricList: [],
+  dashboardName: graph.dashboardName,
 });
-states.isTable = TableChartTypes.includes(graph.type);
 
+states.isTable = TableChartTypes.includes(graph.type);
+states.visTypes = setVisTypes();
 setMetricType();
 
 async function setMetricType(catalog?: string) {
@@ -128,6 +152,47 @@ async function setMetricType(catalog?: string) {
   }
 }
 
+function setVisTypes() {
+  let graphs = [];
+  if (dashboardStore.entity === EntityType[0].value) {
+    graphs = ChartTypes.filter((d: Option) => d.value !== ChartTypes[8].value);
+  } else if (dashboardStore.entity === EntityType[1].value) {
+    graphs = ChartTypes.filter(
+      (d: Option) => !PodsChartTypes.includes(d.value)
+    );
+  } else {
+    graphs = ChartTypes.filter(
+      (d: Option) => !TableChartTypes.includes(d.value)
+    );
+  }
+
+  return graphs;
+}
+
+function changeChartType(item: Option) {
+  const graph = DefaultGraphConfig[item.value];
+  states.isTable = TableChartTypes.includes(graph.type);
+  dashboardStore.selectWidget({ ...dashboardStore.selectedGrid, graph });
+  states.isTable = TableChartTypes.includes(graph.type);
+  if (states.isTable) {
+    dashboardStore.selectWidget({
+      ...dashboardStore.selectedGrid,
+      metrics: [""],
+      metricTypes: [""],
+    });
+    states.metrics = [""];
+    states.metricTypes = [""];
+  }
+  const catalog: { [key: string]: string } = {
+    InstanceList: EntityType[3].value,
+    EndpointList: EntityType[2].value,
+    ServiceList: EntityType[0].value,
+  };
+  if (catalog[graph.type] || dashboardStore.entity) {
+    setMetricType(catalog[graph.type]);
+  }
+}
+
 function changeMetrics(index: number, arr: (Option & { type: string })[]) {
   if (!arr.length) {
     states.metricTypeList = [];
@@ -193,10 +258,10 @@ async function queryMetrics() {
   emit("update", source);
 }
 
-function changeDashboard(item: Option[]) {
+function changeDashboard() {
   const graph = {
     ...dashboardStore.selectedGrid.graph,
-    dashboardName: item[0].value,
+    dashboardName: states.dashboardName,
   };
   dashboardStore.selectWidget({
     ...dashboardStore.selectedGrid,
@@ -216,20 +281,6 @@ function deleteMetric(index: number) {
   states.metrics.splice(index, 1);
   states.metricTypes.splice(index, 1);
 }
-watch(
-  () => dashboardStore.selectedGrid.graph.type,
-  (type: string) => {
-    states.isTable = TableChartTypes.includes(type);
-    const catalog: { [key: string]: string } = {
-      InstanceList: "ServiceInstance",
-      EndpointList: "Endpoint",
-      ServiceList: "Service",
-    };
-    if (catalog[type] || dashboardStore.entity) {
-      setMetricType(catalog[type]);
-    }
-  }
-);
 </script>
 <style lang="scss" scoped>
 .ds-name {
@@ -244,4 +295,24 @@ watch(
 .metric-item {
   margin-bottom: 10px;
 }
+
+.chart-types {
+  span {
+    display: inline-block;
+    padding: 5px 10px;
+    border: 1px solid #ccc;
+    background-color: #fff;
+    border-right: 0;
+    cursor: pointer;
+  }
+
+  span:nth-last-child(1) {
+    border-right: 1px solid #ccc;
+  }
+}
+
+span.active {
+  background-color: #409eff;
+  color: #fff;
+}
 </style>
diff --git a/src/views/dashboard/data.ts b/src/views/dashboard/data.ts
index e643016b..d739217b 100644
--- a/src/views/dashboard/data.ts
+++ b/src/views/dashboard/data.ts
@@ -32,6 +32,18 @@ export const ChartTypes = [
   { label: "Endpoint List", value: "EndpointList" },
   { label: "Instance List", value: "InstanceList" },
 ];
+export const MetricChartType: any = {
+  readMetricsValue: [{ label: "Card", value: "Card" }],
+  readMetricsValues: [
+    { label: "Bar", value: "Bar" },
+    { label: "Line", value: "Line" },
+    { label: "Area", value: "Area" },
+  ],
+  sortMetrics: [{ label: "Top List", value: "TopList" }],
+  readLabeledMetricsValues: [{ label: "Line", value: "Line" }],
+  readHeatMap: [{ label: "Heatmap", value: "Heatmap" }],
+  readSampledRecords: [{ label: "Top List", value: "TopList" }],
+};
 export const DefaultGraphConfig: { [key: string]: any } = {
   Bar: {
     type: "Bar",
@@ -113,14 +125,6 @@ export const MetricTypes: {
     { label: "get sorted topN values", value: "readSampledRecords" },
   ],
 };
-export const MetricChartType: { [key: string]: string } = {
-  readMetricsValue: "ChartNum",
-  readMetricsValues: "ChartLine",
-  sortMetrics: "ChartSlow",
-  readLabeledMetricsValues: "ChartLine",
-  readHeatMap: "ChartHeatmap",
-  readSampledRecords: "ChartSlow",
-};
 
 export enum MetricCatalog {
   SERVICE = "Service",
diff --git a/src/views/dashboard/graphs/EndpointList.vue b/src/views/dashboard/graphs/EndpointList.vue
index c10ddb57..8e9a06d3 100644
--- a/src/views/dashboard/graphs/EndpointList.vue
+++ b/src/views/dashboard/graphs/EndpointList.vue
@@ -29,17 +29,12 @@ limitations under the License. -->
         </template>
       </el-input>
     </div>
-    <el-table
-      v-loading="chartLoading"
-      :data="endpoints"
-      style="width: 100%; height: 320px; overflow: auto"
-    >
+    <el-table v-loading="chartLoading" :data="endpoints" style="width: 100%">
       <el-table-column label="Endpoints">
         <template #default="scope">
           <router-link
-            target="_blank"
             class="link"
-            :to="`/dashboard/${scope.row.layer}/Endpoint/${selectorStore.currentService.id}/${scope.row.id}/${config.dashboardName}`"
+            :to="`/dashboard/${dashboardStore.layerId}/${EntityType[2].value}/${selectorStore.currentService.id}/${scope.row.id}/${config.dashboardName}`"
             :style="{ fontSize: `${config.fontSize}px` }"
           >
             {{ scope.row.label }}
@@ -84,6 +79,7 @@ import { Endpoint } from "@/types/selector";
 import { useDashboardStore } from "@/store/modules/dashboard";
 import { useQueryPodsMetrics, usePodsSource } from "@/hooks/useProcessor";
 import Line from "./Line.vue";
+import { EntityType } from "../data";
 
 /*global defineProps */
 defineProps({
@@ -126,7 +122,7 @@ async function queryEndpointMetrics(currentPods: Endpoint[]) {
     const params = await useQueryPodsMetrics(
       currentPods,
       dashboardStore.selectedGrid,
-      "Endpoint"
+      EntityType[2].value
     );
     const json = await dashboardStore.fetchMetricValue(params);
 
diff --git a/src/views/dashboard/graphs/InstanceList.vue b/src/views/dashboard/graphs/InstanceList.vue
index a42e44fe..046c538d 100644
--- a/src/views/dashboard/graphs/InstanceList.vue
+++ b/src/views/dashboard/graphs/InstanceList.vue
@@ -29,16 +29,12 @@ limitations under the License. -->
         </template>
       </el-input>
     </div>
-    <el-table
-      v-loading="chartLoading"
-      :data="instances"
-      style="width: 100%; height: 320px; overflow: auto"
-    >
+    <el-table v-loading="chartLoading" :data="instances" style="width: 100%">
       <el-table-column label="Service Instances">
         <template #default="scope">
           <router-link
             class="link"
-            :to="`/dashboard/${scope.row.layer}/ServiceInstance/${selectorStore.currentService.id}/${scope.row.id}/${config.dashboardName}`"
+            :to="`/dashboard/${dashboardStore.layerId}/${EntityType[2].value}/${selectorStore.currentService.id}/${scope.row.id}/${config.dashboardName}`"
             :style="{ fontSize: `${config.fontSize}px` }"
           >
             {{ scope.row.label }}
@@ -83,6 +79,7 @@ import { useDashboardStore } from "@/store/modules/dashboard";
 import { InstanceListConfig } from "@/types/dashboard";
 import { Instance } from "@/types/selector";
 import { useQueryPodsMetrics, usePodsSource } from "@/hooks/useProcessor";
+import { EntityType } from "../data";
 
 /*global defineProps */
 defineProps({
@@ -124,7 +121,7 @@ async function queryInstanceMetrics(currentInstances: Instance[]) {
     const params = await useQueryPodsMetrics(
       currentInstances,
       dashboardStore.selectedGrid,
-      "ServiceInstance"
+      EntityType[3].value
     );
     const json = await dashboardStore.fetchMetricValue(params);
 
diff --git a/src/views/dashboard/graphs/ServiceList.vue b/src/views/dashboard/graphs/ServiceList.vue
index 922d5b30..9960abbe 100644
--- a/src/views/dashboard/graphs/ServiceList.vue
+++ b/src/views/dashboard/graphs/ServiceList.vue
@@ -29,17 +29,12 @@ limitations under the License. -->
         </template>
       </el-input>
     </div>
-    <el-table
-      v-loading="chartLoading"
-      :data="services"
-      style="width: 100%; height: 320px; overflow: auto"
-    >
+    <el-table v-loading="chartLoading" :data="services" style="width: 100%">
       <el-table-column label="Services">
         <template #default="scope">
           <router-link
-            target="_blank"
             class="link"
-            :to="`/dashboard/${scope.row.layer}/Service/${selectorStore.currentService.value}/${config.dashboardName}`"
+            :to="`/dashboard/${dashboardStore.layerId}/${EntityType[0].value}/${selectorStore.currentService.id}/${config.dashboardName}`"
             :key="1"
             :style="{ fontSize: `${config.fontSize}px` }"
           >
@@ -85,6 +80,7 @@ import { useSelectorStore } from "@/store/modules/selectors";
 import { useDashboardStore } from "@/store/modules/dashboard";
 import { Service } from "@/types/selector";
 import { useQueryPodsMetrics, usePodsSource } from "@/hooks/useProcessor";
+import { EntityType } from "../data";
 
 /*global defineProps */
 defineProps({
@@ -124,7 +120,7 @@ async function queryServiceMetrics(currentServices: Service[]) {
     const params = await useQueryPodsMetrics(
       currentServices,
       dashboardStore.selectedGrid,
-      "Service"
+      EntityType[0].value
     );
     const json = await dashboardStore.fetchMetricValue(params);
 
diff --git a/src/views/dashboard/panel/Tool.vue b/src/views/dashboard/panel/Tool.vue
index ccbe971b..18cdcd1f 100644
--- a/src/views/dashboard/panel/Tool.vue
+++ b/src/views/dashboard/panel/Tool.vue
@@ -13,9 +13,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License. -->
 <template>
-  <div class="dashboard-tool flex-h">
-    <div v-if="params.serviceId"></div>
-    <div class="flex-h" v-else>
+  <div class="dashboard-tool flex-h" v-if="!params.serviceId">
+    <div class="flex-h">
       <div class="selectors-item" v-if="states.key !== 10">
         <span class="label">$Service</span>
         <Selector