From acf8830a28b9892fa5c2030bcf62dc328da77a76 Mon Sep 17 00:00:00 2001
From: Qiuxia Fan <fine0830@outlook.com>
Date: Fri, 4 Mar 2022 15:23:51 +0800
Subject: [PATCH] feat: edit tab name

---
 src/locales/lang/en.ts               |  1 +
 src/locales/lang/zh.ts               |  1 +
 src/views/dashboard/controls/Tab.vue | 64 +++++++++++++++++++++++++---
 3 files changed, 61 insertions(+), 5 deletions(-)

diff --git a/src/locales/lang/en.ts b/src/locales/lang/en.ts
index 29feac0c..b3649192 100644
--- a/src/locales/lang/en.ts
+++ b/src/locales/lang/en.ts
@@ -95,6 +95,7 @@ const msg = {
   topChildren: "Top 5 of children",
   taskList: "Task List",
   sampledTraces: "Sampled Traces",
+  editTab: "Enable editing tab names",
   hourTip: "Select Hour",
   minuteTip: "Select Minute",
   secondTip: "Select Second",
diff --git a/src/locales/lang/zh.ts b/src/locales/lang/zh.ts
index 5764eeed..d60322cf 100644
--- a/src/locales/lang/zh.ts
+++ b/src/locales/lang/zh.ts
@@ -95,6 +95,7 @@ const msg = {
   showDepth: "展示深度选择器",
   taskList: "任务列表",
   sampledTraces: "采样的追踪",
+  editTab: "开启编辑Tab的名称",
   hourTip: "选择小时",
   minuteTip: "选择分钟",
   secondTip: "选择秒数",
diff --git a/src/views/dashboard/controls/Tab.vue b/src/views/dashboard/controls/Tab.vue
index f74314da..20c106dd 100644
--- a/src/views/dashboard/controls/Tab.vue
+++ b/src/views/dashboard/controls/Tab.vue
@@ -45,10 +45,38 @@ limitations under the License. -->
       </span>
     </div>
     <div class="operations">
-      <Icon size="sm" iconName="clearclose" @click="removeTab" />
+      <el-popover
+        placement="bottom"
+        trigger="click"
+        :width="200"
+        v-model:visible="showTools"
+      >
+        <template #reference>
+          <span>
+            <Icon
+              iconName="ellipsis_v"
+              size="middle"
+              class="operation"
+              @click="showTools = true"
+            />
+          </span>
+        </template>
+        <div
+          class="tools"
+          @click="
+            canEditTabName = true;
+            showTools = false;
+          "
+        >
+          <span class="edit-tab">{{ t("editTab") }}</span>
+        </div>
+        <div class="tools" @click="removeTab">
+          <span>{{ t("delete") }}</span>
+        </div>
+      </el-popover>
     </div>
   </div>
-  <div class="tab-layout">
+  <div class="tab-layout" @click="handleClick">
     <grid-layout
       v-if="dashboardStore.currentTabItems.length"
       v-model:layout="dashboardStore.currentTabItems"
@@ -83,6 +111,7 @@ limitations under the License. -->
 </template>
 <script lang="ts">
 import { ref, watch, defineComponent, toRefs } from "vue";
+import { useI18n } from "vue-i18n";
 import type { PropType } from "vue";
 import { LayoutConfig } from "@/types/dashboard";
 import { useDashboardStore } from "@/store/modules/dashboard";
@@ -103,11 +132,14 @@ export default defineComponent({
   components: { Topology, Widget, Trace, Profile },
   props,
   setup(props) {
+    const { t } = useI18n();
     const dashboardStore = useDashboardStore();
     const activeTabIndex = ref<number>(0);
     const activeTabWidget = ref<string>("");
     const editTabIndex = ref<number>(NaN); // edit tab item name
+    const canEditTabName = ref<boolean>(false);
     const needQuery = ref<boolean>(false);
+    const showTools = ref<boolean>(false);
     const l = dashboardStore.layout.findIndex(
       (d: LayoutConfig) => d.i === props.data.i
     );
@@ -141,13 +173,17 @@ export default defineComponent({
       dashboardStore.addTabItem(props.data);
     }
     function editTabName(el: Event, index: number) {
-      el.stopPropagation();
+      if (!canEditTabName.value) {
+        editTabIndex.value = NaN;
+        return;
+      }
       editTabIndex.value = index;
     }
     function handleClick(el: any) {
-      if (el.target.className === "tab-name") {
+      if (["tab-name", "edit-tab"].includes(el.target.className)) {
         return;
       }
+      canEditTabName.value = false;
       editTabIndex.value = NaN;
     }
     function clickTabGrid(e: Event, item: LayoutConfig) {
@@ -156,6 +192,7 @@ export default defineComponent({
       dashboardStore.activeGridItem(
         `${props.data.i}-${activeTabIndex.value}-${item.i}`
       );
+      handleClick(e);
     }
     function layoutUpdatedEvent() {
       const l = dashboardStore.layout.findIndex(
@@ -182,6 +219,7 @@ export default defineComponent({
       }
     );
     return {
+      handleClick,
       layoutUpdatedEvent,
       clickTabGrid,
       editTabName,
@@ -195,6 +233,9 @@ export default defineComponent({
       activeTabIndex,
       editTabIndex,
       needQuery,
+      canEditTabName,
+      showTools,
+      t,
     };
   },
 });
@@ -206,7 +247,7 @@ export default defineComponent({
 
   span {
     display: inline-block;
-    padding: 0 20px;
+    padding: 0 10px;
     margin: 0 10px;
     height: 40px;
     line-height: 40px;
@@ -286,4 +327,17 @@ export default defineComponent({
   padding-top: 30px;
   color: #888;
 }
+
+.tools {
+  padding: 5px 0;
+  color: #999;
+  cursor: pointer;
+  position: relative;
+  text-align: center;
+
+  &:hover {
+    color: #409eff;
+    background-color: #eee;
+  }
+}
 </style>