github/ttrpc
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mgrpc: decrease size of channel buffers

Browse Source 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2017-11-15 17:01:30 -08:00
parent 484a09bfa0
commit 52978c11e8
No known key found for this signature in database
GPG Key ID: 67B3DED84EDC823F
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
channel.go
View File

@ -12,6 +12,8 @@ import (
"github.com/pkg/errors" "github.com/pkg/errors"
) )
const maxMessageSize = 8 << 10 // TODO(stevvooe): Cut these down, since they are pre-alloced.
type channel struct { type channel struct {
conn net.Conn conn net.Conn
bw *bufio.Writer bw *bufio.Writer
@ -21,13 +23,15 @@ type channel struct {
func newChannel(conn net.Conn) *channel { func newChannel(conn net.Conn) *channel {
return &channel{ return &channel{
conn: conn, conn: conn,
bw: bufio.NewWriter(conn), bw: bufio.NewWriterSize(conn, maxMessageSize),
br: bufio.NewReader(conn), br: bufio.NewReaderSize(conn, maxMessageSize),
} }
} }
func (ch *channel) recv(ctx context.Context, msg interface{}) error { func (ch *channel) recv(ctx context.Context, msg interface{}) error {
defer log.G(ctx).WithField("msg", msg).Info("recv") defer log.G(ctx).WithField("msg", msg).Info("recv")
// TODO(stevvooe): Use `bufio.Reader.Peek` here to remove this allocation.
var p [maxMessageSize]byte var p [maxMessageSize]byte
n, err := readmsg(ch.br, p[:]) n, err := readmsg(ch.br, p[:])
if err != nil { if err != nil {

2
server.go
View File

@ -46,8 +46,6 @@ func (s *Server) Serve(l net.Listener) error {
return nil return nil
} }
const maxMessageSize = 1 << 20 // TODO(stevvooe): Cut these down, since they are pre-alloced.
func (s *Server) handleConn(conn net.Conn) { func (s *Server) handleConn(conn net.Conn) {
defer conn.Close() defer conn.Close()