mirror of
https://github.com/cloud-hypervisor/cloud-hypervisor.git
synced 2026-08-05 02:19:16 +00:00
vm-migration: improve debuggability on receiver for failed migrations
We cannot reliably send Request::abandon() on every kind of failure on the sender side, as we might be in the middle of a memory transmission. The receiver would not reliably know what to do with that. So instead, when the receiver cannot read from the socket, we log that the migration sender failed, which is the only likely cause of that failure. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This commit is contained in:
committed by
Bo Chen
parent
81022ab087
commit
013981b649
@@ -283,7 +283,7 @@ fn run_snapshot(socket_path: &Path, output_dir: &Path) -> Result<()> {
|
||||
break;
|
||||
}
|
||||
Command::Abandon => {
|
||||
// ACK before bailing so CH's ok_or_abandon read returns
|
||||
// ACK before bailing so CH's ok_or_fatal_error() read returns
|
||||
// cleanly instead of hitting EOF.
|
||||
Response::ok().write_to(&mut stream).ok();
|
||||
return Err(Error::Abandoned);
|
||||
|
||||
Reference in New Issue
Block a user