From 09c3ddd47de9e91411a5d9db5b0532bf3704690b Mon Sep 17 00:00:00 2001 From: Sebastien Boeuf Date: Thu, 17 Jun 2021 11:16:24 +0200 Subject: [PATCH] vmm: memory_manager: Remove _PXM from ACPI memory slot The _PXM method always return 0, which is wrong since the SRAT might tell differently. The point of the _PXM method is to be evaluated by the guest OS when some new memory slot is being plugged, but this will never happen for Cloud Hypervisor since using NUMA nodes along with memory hotplug only works for virtio-mem. Memory hotplug through ACPI will only happen when there's only one NUMA node exposed to the guest, which means the _PXM method won't be needed at all. Signed-off-by: Sebastien Boeuf --- vmm/src/memory_manager.rs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/vmm/src/memory_manager.rs b/vmm/src/memory_manager.rs index 8ce8c01dd..5e6dd7209 100644 --- a/vmm/src/memory_manager.rs +++ b/vmm/src/memory_manager.rs @@ -1614,14 +1614,6 @@ impl Aml for MemorySlot { vec![&self.slot_id], ))], ), - // We don't expose any NUMA characteristics so all memory is in the same "proximity domain" - &aml::Method::new( - "_PXM".into(), - 0, - false, - // We aren't NUMA so associate all RAM into the same proximity region (zero) - vec![&aml::Return::new(&0u32)], - ), ], ) .to_aml_bytes()