kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix clippy issue related to passing by value

Browse Source 
warning: this argument is passed by value, but not consumed in the function body
    --> cloud-hypervisor/tests/integration.rs:3785:51
     |
3785 |     fn run_multiqueue_qcow2_test<F>(image_config: QcowTestImageConfig, test_fn: F)
     |                                                   ^^^^^^^^^^^^^^^^^^^
     |
help: or consider marking this type as `Copy`
    --> cloud-hypervisor/tests/integration.rs:3774:5
     |
3774 |     enum QcowTestImageConfig {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
     = note: requested on the command line with `-D clippy::needless-pass-by-value`

Signed-off-by: Rob Bradford <rbradford@meta.com>
This commit is contained in:
Rob Bradford
2026-03-15 03:01:27 -07:00
parent 0a7e32c312
commit 14d8cf5f1e
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cloud-hypervisor/tests/integration.rs
+11 -11
View File
@@ -3782,7 +3782,7 @@ mod common_parallel {
/// ///
/// Creates a VM with multiple virtio queues on the test disk, then runs the /// Creates a VM with multiple virtio queues on the test disk, then runs the
/// provided test closure. Handles VM lifecycle and consistency checks. /// provided test closure. Handles VM lifecycle and consistency checks.
fn run_multiqueue_qcow2_test<F>(image_config: QcowTestImageConfig, test_fn: F) fn run_multiqueue_qcow2_test<F>(image_config: &QcowTestImageConfig, test_fn: F)
where where
F: FnOnce(&Guest) + std::panic::UnwindSafe, F: FnOnce(&Guest) + std::panic::UnwindSafe,
{ {
@@ -3793,7 +3793,7 @@ mod common_parallel {
let test_image_path = guest.tmp_dir.as_path().join("test.qcow2"); let test_image_path = guest.tmp_dir.as_path().join("test.qcow2");
// Create test image based on configuration and capture backing checksum if applicable // Create test image based on configuration and capture backing checksum if applicable
let initial_backing_checksum = match image_config { let initial_backing_checksum = match *image_config {
QcowTestImageConfig::Simple(size) => { QcowTestImageConfig::Simple(size) => {
Command::new("qemu-img") Command::new("qemu-img")
.arg("create") .arg("create")
@@ -3876,7 +3876,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_writes() { fn test_virtio_block_qcow2_multiqueue_writes() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("256M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("256M"), |guest| {
assert_eq!( assert_eq!(
guest guest
.ssh_command("ls -ll /sys/block/vdc/mq | grep ^d | wc -l") .ssh_command("ls -ll /sys/block/vdc/mq | grep ^d | wc -l")
@@ -3946,7 +3946,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_mixed_rw() { fn test_virtio_block_qcow2_multiqueue_mixed_rw() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("512M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("512M"), |guest| {
guest guest
.ssh_command("sudo mkfs.ext4 -F /dev/vdc") .ssh_command("sudo mkfs.ext4 -F /dev/vdc")
.expect("Failed to format disk"); .expect("Failed to format disk");
@@ -3997,7 +3997,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_backing() { fn test_virtio_block_qcow2_multiqueue_backing() {
run_multiqueue_qcow2_test(QcowTestImageConfig::WithBacking, |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::WithBacking, |guest| {
guest guest
.ssh_command("sudo mkfs.ext4 -F /dev/vdc") .ssh_command("sudo mkfs.ext4 -F /dev/vdc")
.expect("Failed to format disk"); .expect("Failed to format disk");
@@ -4041,7 +4041,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_random_4k() { fn test_virtio_block_qcow2_multiqueue_random_4k() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("256M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("256M"), |guest| {
guest guest
.ssh_command( .ssh_command(
"for i in $(seq 1 8); do \ "for i in $(seq 1 8); do \
@@ -4071,7 +4071,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_fsync() { fn test_virtio_block_qcow2_multiqueue_fsync() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("256M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("256M"), |guest| {
guest guest
.ssh_command("sudo mkfs.ext4 -F /dev/vdc") .ssh_command("sudo mkfs.ext4 -F /dev/vdc")
.expect("Failed to format disk"); .expect("Failed to format disk");
@@ -4118,7 +4118,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_metadata() { fn test_virtio_block_qcow2_multiqueue_metadata() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("256M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("256M"), |guest| {
guest guest
.ssh_command("sudo mkfs.ext4 -F /dev/vdc") .ssh_command("sudo mkfs.ext4 -F /dev/vdc")
.expect("Failed to format disk"); .expect("Failed to format disk");
@@ -4197,7 +4197,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_discard_mount() { fn test_virtio_block_qcow2_multiqueue_discard_mount() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("256M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("256M"), |guest| {
guest guest
.ssh_command("sudo mkfs.ext4 -F /dev/vdc") .ssh_command("sudo mkfs.ext4 -F /dev/vdc")
.expect("Failed to format disk"); .expect("Failed to format disk");
@@ -4260,7 +4260,7 @@ mod common_parallel {
} }
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_wide_writes() { fn test_virtio_block_qcow2_multiqueue_wide_writes() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("1G"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("1G"), |guest| {
// Scattered write pattern - write to widely separated offsets in parallel. // Scattered write pattern - write to widely separated offsets in parallel.
// This should initiate many L2 table allocations simultaneously across different queues. // This should initiate many L2 table allocations simultaneously across different queues.
guest guest
@@ -4300,7 +4300,7 @@ mod common_parallel {
#[test] #[test]
fn test_virtio_block_qcow2_multiqueue_discard_stress() { fn test_virtio_block_qcow2_multiqueue_discard_stress() {
run_multiqueue_qcow2_test(QcowTestImageConfig::Simple("512M"), |guest| { run_multiqueue_qcow2_test(&QcowTestImageConfig::Simple("512M"), |guest| {
guest guest
.ssh_command("sudo mkfs.ext4 -F /dev/vdc") .ssh_command("sudo mkfs.ext4 -F /dev/vdc")
.expect("Failed to format disk"); .expect("Failed to format disk");