kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

virtio-devices: Drop unused device_needs_reset helper

Browse Source 
With the per handler needs_reset() gates removed from net and
block, nothing reads DEVICE_NEEDS_RESET anymore. Drop the
device_needs_reset helper and refresh the doc comment on
mark_device_needs_reset to reflect the central call site in
spawn_virtio_thread, where it runs after the worker has already
exited.

No functional change.

Signed-off-by: Anatol Belski <anbelski@linux.microsoft.com>
This commit is contained in:
Anatol Belski
2026-05-07 14:49:18 +02:00
committed by Rob Bradford
parent 293672ea76
commit 14dfd78f04
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
virtio-devices/src/lib.rs
View File

@@ -70,15 +70,10 @@ const DEVICE_FEATURES_OK: u32 = 0x08;
const DEVICE_NEEDS_RESET: u32 = 0x40; const DEVICE_NEEDS_RESET: u32 = 0x40;
const DEVICE_FAILED: u32 = 0x80; const DEVICE_FAILED: u32 = 0x80;
/// Returns true if `device_status` has the `DEVICE_NEEDS_RESET` bit set.
pub(crate) fn device_needs_reset(device_status: &AtomicU8) -> bool {
(device_status.load(Ordering::Acquire) & DEVICE_NEEDS_RESET as u8) != 0
}
/// Marks a virtio device as `NEEDS_RESET` and notifies the guest via a config /// Marks a virtio device as `NEEDS_RESET` and notifies the guest via a config
/// change interrupt. Used when a guest induced error (corrupted virtqueue, /// change interrupt. Used when a guest induced error (corrupted virtqueue,
/// malformed descriptor chain or similar) is detected and the device wants /// malformed descriptor chain or similar) is detected and the worker thread
/// to stop further queue processing without killing the worker thread. /// has stopped processing the device's queues.
/// ///
/// `context` is included verbatim in the warning log to identify the cause. /// `context` is included verbatim in the warning log to identify the cause.
pub(crate) fn mark_device_needs_reset( pub(crate) fn mark_device_needs_reset(