From 19ca5c0b84c8afef639715028fceb69ceef3fae7 Mon Sep 17 00:00:00 2001 From: Bo Chen Date: Mon, 12 Jun 2023 11:17:57 -0700 Subject: [PATCH] vmm: Clarify memory regions are required to be page-size aligned Signed-off-by: Bo Chen --- vmm/src/memory_manager.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vmm/src/memory_manager.rs b/vmm/src/memory_manager.rs index 262c0c08a..fbb08d7c1 100644 --- a/vmm/src/memory_manager.rs +++ b/vmm/src/memory_manager.rs @@ -519,6 +519,9 @@ impl MemoryManager { /// - First one mapping entirely the first memory zone on 0-1G range /// - Second one mapping partially the second memory zone on 1G-3G range /// - Third one mapping partially the second memory zone on 4G-6G range + /// Also, all memory regions are page-size aligned (e.g. their sizes must + /// be multiple of page-size), which may leave an additional hole in the + /// address space when hugepage is used. fn create_memory_regions_from_zones( ram_regions: &[(GuestAddress, usize)], zones: &[MemoryZoneConfig],