kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

block: Remove legacy async I/O API

Browse Source 
Drop the borrowed iovec AsyncIo entry points now that all callers use
owned operations. Rename the transitional owned batch and completion
methods to the final trait names and remove the borrowed submission
helpers from the queue wrappers.

This removes a bunch of known safety foot-guns so future-us don't
accidentally use them.

Assisted-by: Codex:GPT-5.5
Signed-off-by: Dylan Reid <dgreid@fb.com>
This commit is contained in:
Dylan Reid
2026-05-19 14:25:12 -07:00
committed by Rob Bradford
parent 2da8507d21
commit 1b2326fde4
19 changed files with 54 additions and 831 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
block/src/vhdx_sync.rs
View File

@@ -191,36 +191,6 @@ impl AsyncIo for VhdxSync {
&self.eventfd
}
fn read_vectored(
&mut self,
offset: libc::off_t,
iovecs: &[libc::iovec],
user_data: u64,
) -> AsyncIoResult<()> {
// SAFETY: the legacy caller is responsible for keeping the borrowed
// iovecs and writable buffers valid until completion. This is unsound, but only temporary.
let result = unsafe { self.read_iovecs(offset, iovecs)? };
self.completion_list
.push_back(AsyncIoCompletion::new(user_data, result as i32, None));
self.eventfd.write(1).unwrap();
Ok(())
}
fn write_vectored(
&mut self,
offset: libc::off_t,
iovecs: &[libc::iovec],
user_data: u64,
) -> AsyncIoResult<()> {
// SAFETY: the legacy caller is responsible for keeping the borrowed
// iovecs and readable buffers valid until completion. This is unsound, but only temporary.
let result = unsafe { self.write_iovecs(offset, iovecs)? };
self.completion_list
.push_back(AsyncIoCompletion::new(user_data, result as i32, None));
self.eventfd.write(1).unwrap();
Ok(())
}
fn submit_data_operation(&mut self, op: AsyncIoOperation) -> AsyncIoResult<()> {
let offset = op.offset();
let is_read = op.is_read();
@@ -259,7 +229,7 @@ impl AsyncIo for VhdxSync {
Ok(())
}
fn next_completion(&mut self) -> Option<AsyncIoCompletion> {
fn next_completed_request(&mut self) -> Option<AsyncIoCompletion> {
self.completion_list.pop_front()
}