From 221c1f1bdc4fcab8268565967220b5b93d86f471 Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Fri, 7 Jan 2022 10:26:07 +0000 Subject: [PATCH] pci: Fix clippy (return_self_not_must_use) issue warning: missing `#[must_use]` attribute on a method returning `Self` --> pci/src/configuration.rs:925:5 | 925 | / pub fn set_register_index(mut self, reg_idx: usize) -> Self { 926 | | self.reg_idx = reg_idx; 927 | | self 928 | | } | |_____^ | = note: `#[warn(clippy::return_self_not_must_use)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use warning: missing `#[must_use]` attribute on a method returning `Self` --> pci/src/configuration.rs:930:5 | 930 | / pub fn set_address(mut self, addr: u64) -> Self { 931 | | self.addr = addr; 932 | | self 933 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use warning: missing `#[must_use]` attribute on a method returning `Self` --> pci/src/configuration.rs:935:5 | 935 | / pub fn set_size(mut self, size: u64) -> Self { 936 | | self.size = size; 937 | | self 938 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use warning: missing `#[must_use]` attribute on a method returning `Self` --> pci/src/configuration.rs:944:5 | 944 | / pub fn set_region_type(mut self, region_type: PciBarRegionType) -> Self { 945 | | self.region_type = region_type; 946 | | self 947 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#return_self_not_must_use Signed-off-by: Rob Bradford --- pci/src/configuration.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pci/src/configuration.rs b/pci/src/configuration.rs index f4a190a66..300d4c410 100644 --- a/pci/src/configuration.rs +++ b/pci/src/configuration.rs @@ -922,16 +922,19 @@ impl PciBarConfiguration { } } + #[must_use] pub fn set_register_index(mut self, reg_idx: usize) -> Self { self.reg_idx = reg_idx; self } + #[must_use] pub fn set_address(mut self, addr: u64) -> Self { self.addr = addr; self } + #[must_use] pub fn set_size(mut self, size: u64) -> Self { self.size = size; self @@ -941,6 +944,7 @@ impl PciBarConfiguration { self.size } + #[must_use] pub fn set_region_type(mut self, region_type: PciBarRegionType) -> Self { self.region_type = region_type; self