From 3a6df69d45cb98ed5748903834d7ae234f268b12 Mon Sep 17 00:00:00 2001 From: Akira Moroo Date: Wed, 23 Feb 2022 13:19:44 +0900 Subject: [PATCH] virtio-devices: Fix clippy::ptr-arg issue error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> virtio-devices/src/transport/pci_common_config.rs:93:17 | 93 | queues: &mut Vec>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Queue>]` | = note: `-D clippy::ptr-arg` implied by `-D warnings` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg Signed-off-by: Akira Moroo --- virtio-devices/src/transport/pci_common_config.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/virtio-devices/src/transport/pci_common_config.rs b/virtio-devices/src/transport/pci_common_config.rs index 8bb92d463..07e1f2780 100644 --- a/virtio-devices/src/transport/pci_common_config.rs +++ b/virtio-devices/src/transport/pci_common_config.rs @@ -90,7 +90,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, data: &mut [u8], - queues: &mut Vec>>, + queues: &mut [Queue>], device: Arc>, ) { assert!(data.len() <= 8); @@ -120,7 +120,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, data: &[u8], - queues: &mut Vec>>, + queues: &mut [Queue>], device: Arc>, ) { assert!(data.len() <= 8); @@ -190,7 +190,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, value: u16, - queues: &mut Vec>>, + queues: &mut [Queue>], ) { debug!("write_common_config_word: offset 0x{:x}", offset); match offset { @@ -256,7 +256,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, value: u32, - queues: &mut Vec>>, + queues: &mut [Queue>], device: Arc>, ) { debug!("write_common_config_dword: offset 0x{:x}", offset); @@ -304,7 +304,7 @@ impl VirtioPciCommonConfig { &mut self, offset: u64, value: u64, - queues: &mut Vec>>, + queues: &mut [Queue>], ) { debug!("write_common_config_qword: offset 0x{:x}", offset); match offset { @@ -330,7 +330,7 @@ impl VirtioPciCommonConfig { fn with_queue_mut>)>( &self, - queues: &mut Vec>>, + queues: &mut [Queue>], f: F, ) { if let Some(queue) = queues.get_mut(self.queue_select as usize) {