From 521a0d1ade8deb34ba3706e8b7a1b38d1f286026 Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Tue, 19 Mar 2024 16:36:05 +0000 Subject: [PATCH] vmm: Fix clippy warnings for use of .clone() warning: assigning the result of `Clone::clone()` may be inefficient --> vmm/src/device_manager.rs:4188:17 | 4188 | id = child_id.clone(); | ^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `id.clone_from(child_id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default Signed-off-by: Rob Bradford --- vmm/src/device_manager.rs | 2 +- vmm/src/device_tree.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vmm/src/device_manager.rs b/vmm/src/device_manager.rs index d8c57847a..bad43d19f 100644 --- a/vmm/src/device_manager.rs +++ b/vmm/src/device_manager.rs @@ -4185,7 +4185,7 @@ impl DeviceManager { if !pci_device_node.children.is_empty() { assert_eq!(pci_device_node.children.len(), 1); let child_id = &pci_device_node.children[0]; - id = child_id.clone(); + id.clone_from(child_id); } } for child in pci_device_node.children.iter() { diff --git a/vmm/src/device_tree.rs b/vmm/src/device_tree.rs index 976cc6ab6..66da13d35 100644 --- a/vmm/src/device_tree.rs +++ b/vmm/src/device_tree.rs @@ -175,7 +175,7 @@ mod tests { // Check get_mut() let node = device_tree.get_mut(&id).unwrap(); - node.id = id2.clone(); + node.id.clone_from(&id2); let node = device_tree.0.get(&id).unwrap(); assert_eq!(node.id, id2);