kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

block: qcow: Reject backing file offset with zero size

Browse Source 
A qcow2 header with non-zero backing_file_offset that points at a
zero length name is malformed. The parser would otherwise read an
empty path string and store it as a backing file. Reject it with a
dedicated error so the user gets a clear diagnostic.

Signed-off-by: Anatol Belski <anbelski@linux.microsoft.com>
This commit is contained in:
Anatol Belski
2026-06-01 17:35:10 +02:00
committed by Rob Bradford
parent 39e9376f5b
commit 53a9ae08c2
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
block/src/formats/qcow/internal/header.rs
View File

@@ -336,6 +336,11 @@ impl QcowHeader {
header.backing_file_size, header.backing_file_size,
)); ));
} }
if header.backing_file_offset != 0 && header.backing_file_size == 0 {
return Err(Error::BackingFileOffsetWithoutSize(
header.backing_file_offset,
));
}
if header.backing_file_offset != 0 { if header.backing_file_offset != 0 {
let cluster_size = 1u64 let cluster_size = 1u64
.checked_shl(header.cluster_bits) .checked_shl(header.cluster_bits)

2
block/src/formats/qcow/internal/mod.rs
View File

@@ -66,6 +66,8 @@ use crate::error::{BlockError, BlockErrorKind, BlockResult};
pub enum Error { pub enum Error {
#[error("Backing file I/O error: {0}")] #[error("Backing file I/O error: {0}")]
BackingFileIo(String /* path */, #[source] io::Error), BackingFileIo(String /* path */, #[source] io::Error),
#[error("Backing file offset {0:#x} with zero size")]
BackingFileOffsetWithoutSize(u64),
#[error("Backing file open error: {0}")] #[error("Backing file open error: {0}")]
BackingFileOpen(String /* path */, #[source] Box<Error>), BackingFileOpen(String /* path */, #[source] Box<Error>),
#[error( #[error(