From 56696ed901d6f0045eb9e5fd6c91a635562235a4 Mon Sep 17 00:00:00 2001 From: Muminul Islam Date: Sat, 21 Mar 2026 00:55:52 -0700 Subject: [PATCH] tests: extract _test_split_irqchip to tests_wrappers Move the split IRQ chip test logic from integration.rs into a shared _test_split_irqchip() function in tests_wrappers.rs. The original test now delegates to this shared function, enabling reuse by CVM tests. Signed-off-by: Muminul Islam --- .../tests/common/tests_wrappers.rs | 41 ++++++++++++++++++ cloud-hypervisor/tests/integration.rs | 43 +------------------ 2 files changed, 43 insertions(+), 41 deletions(-) diff --git a/cloud-hypervisor/tests/common/tests_wrappers.rs b/cloud-hypervisor/tests/common/tests_wrappers.rs index fa14ac6b9..2663a6499 100644 --- a/cloud-hypervisor/tests/common/tests_wrappers.rs +++ b/cloud-hypervisor/tests/common/tests_wrappers.rs @@ -2139,3 +2139,44 @@ fn vhdx_image_size(disk_name: &str) -> u64 { .seek(SeekFrom::End(0)) .unwrap() } + +#[cfg(target_arch = "x86_64")] +pub fn _test_split_irqchip(guest: &Guest) { + let mut child = GuestCommand::new(guest) + .default_cpus() + .default_memory() + .default_kernel_cmdline() + .default_disks() + .default_net() + .capture_output() + .spawn() + .unwrap(); + + let r = std::panic::catch_unwind(|| { + guest.wait_vm_boot().unwrap(); + + assert_eq!( + guest + .ssh_command("grep -c IO-APIC.*timer /proc/interrupts || true") + .unwrap() + .trim() + .parse::() + .unwrap_or(1), + 0 + ); + assert_eq!( + guest + .ssh_command("grep -c IO-APIC.*cascade /proc/interrupts || true") + .unwrap() + .trim() + .parse::() + .unwrap_or(1), + 0 + ); + }); + + kill_child(&mut child); + let output = child.wait_with_output().unwrap(); + + handle_child_output(r, &output); +} diff --git a/cloud-hypervisor/tests/integration.rs b/cloud-hypervisor/tests/integration.rs index b17ecfa7e..1b6562fab 100644 --- a/cloud-hypervisor/tests/integration.rs +++ b/cloud-hypervisor/tests/integration.rs @@ -1731,47 +1731,8 @@ mod common_parallel { #[test] #[cfg(target_arch = "x86_64")] fn test_split_irqchip() { - let disk_config = UbuntuDiskConfig::new(JAMMY_IMAGE_NAME.to_string()); - let guest = Guest::new(Box::new(disk_config)); - - let mut child = GuestCommand::new(&guest) - .default_cpus() - .default_memory() - .args(["--kernel", direct_kernel_boot_path().to_str().unwrap()]) - .args(["--cmdline", DIRECT_KERNEL_BOOT_CMDLINE]) - .default_disks() - .default_net() - .capture_output() - .spawn() - .unwrap(); - - let r = std::panic::catch_unwind(|| { - guest.wait_vm_boot().unwrap(); - - assert_eq!( - guest - .ssh_command("grep -c IO-APIC.*timer /proc/interrupts || true") - .unwrap() - .trim() - .parse::() - .unwrap_or(1), - 0 - ); - assert_eq!( - guest - .ssh_command("grep -c IO-APIC.*cascade /proc/interrupts || true") - .unwrap() - .trim() - .parse::() - .unwrap_or(1), - 0 - ); - }); - - kill_child(&mut child); - let output = child.wait_with_output().unwrap(); - - handle_child_output(r, &output); + let guest = basic_regular_guest!(JAMMY_IMAGE_NAME); + _test_split_irqchip(&guest); } #[test]