kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

clippy: Address the issue 'needless-borrow'

Browse Source 
Issue from beta verion of clippy:

Error:    --> vm-virtio/src/queue.rs:700:59
    |
700 |             if let Some(used_event) = self.get_used_event(&mem) {
    |                                                           ^^^^ help: change this to: `mem`
    |
    = note: `-D clippy::needless-borrow` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Signed-off-by: Bo Chen <chen.bo@intel.com>
This commit is contained in:
Bo Chen
2021-06-23 13:42:17 -07:00
committed by Sebastien Boeuf
parent 585269ecb9
commit 5825ab2dd4
30 changed files with 74 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
vmm/src/api/http.rs
View File

@@ -241,7 +241,7 @@ fn handle_http_request(
let path = request.uri().get_abs_path().to_string();
let mut response = match HTTP_ROUTES.routes.get(&path) {
Some(route) => match api_notifier.try_clone() {
Ok(notifier) => route.handle_request(&request, notifier, api_sender.clone()),
Ok(notifier) => route.handle_request(request, notifier, api_sender.clone()),
Err(_) => error_response(
HttpError::InternalServerError,
StatusCode::InternalServerError,

8
vmm/src/device_manager.rs
View File

@@ -3159,7 +3159,7 @@ impl DeviceManager {
device_cfg: &mut DeviceConfig,
) -> DeviceManagerResult<PciDeviceInfo> {
let pci = if let Some(pci_bus) = &self.pci_bus {
Arc::clone(&pci_bus)
Arc::clone(pci_bus)
} else {
return Err(DeviceManagerError::NoPciBus);
};
@@ -3235,7 +3235,7 @@ impl DeviceManager {
pub fn eject_device(&mut self, device_id: u8) -> DeviceManagerResult<()> {
// Retrieve the PCI bus.
let pci = if let Some(pci_bus) = &self.pci_bus {
Arc::clone(&pci_bus)
Arc::clone(pci_bus)
} else {
return Err(DeviceManagerError::NoPciBus);
};
@@ -3382,7 +3382,7 @@ impl DeviceManager {
}
let pci = if let Some(pci_bus) = &self.pci_bus {
Arc::clone(&pci_bus)
Arc::clone(pci_bus)
} else {
return Err(DeviceManagerError::NoPciBus);
};
@@ -4049,7 +4049,7 @@ impl BusDevice for DeviceManager {
B0EJ_FIELD_OFFSET => {
assert!(data.len() == B0EJ_FIELD_SIZE);
let mut data_array: [u8; 4] = [0, 0, 0, 0];
data_array.copy_from_slice(&data);
data_array.copy_from_slice(data);
let device_bitmap = u32::from_le_bytes(data_array);
for device_id in 0..32 {

4
vmm/src/vm.rs
View File

@@ -1186,7 +1186,7 @@ impl Vm {
self.device_manager
.lock()
.unwrap()
.update_memory(&new_region)
.update_memory(new_region)
.map_err(Error::DeviceManager)?;
match memory_config.hotplug_method {
@@ -2580,7 +2580,7 @@ pub fn test_vm() {
println!(
"IO out -- addr: {:#x} data [{:?}]",
addr,
str::from_utf8(&data).unwrap()
str::from_utf8(data).unwrap()
);
}
VmExit::Reset => {