From 59f98a2edc3c5ff467c0d3e20b490413afd6c2f6 Mon Sep 17 00:00:00 2001 From: Bo Chen Date: Fri, 9 May 2025 18:58:38 +0000 Subject: [PATCH] pci: configuration: Log BAR reprogramming correctly Use the right bar index and bar address maintained internally by the VMM when logging BAR reprogramming. Signed-off-by: Bo Chen --- pci/src/configuration.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pci/src/configuration.rs b/pci/src/configuration.rs index 94bd83222..e10afb47a 100644 --- a/pci/src/configuration.rs +++ b/pci/src/configuration.rs @@ -988,7 +988,7 @@ impl PciConfiguration { info!( "Detected BAR reprogramming: (BAR {}) 0x{:x}->0x{:x}", - reg_idx, self.registers[reg_idx], value + bar_idx, self.bars[bar_idx].addr, value ); let old_base = u64::from(self.bars[bar_idx].addr & mask); let new_base = u64::from(value & mask); @@ -1014,7 +1014,7 @@ impl PciConfiguration { { info!( "Detected BAR reprogramming: (BAR {}) 0x{:x}->0x{:x}", - reg_idx, self.registers[reg_idx], value + bar_idx, self.bars[bar_idx].addr, value ); let old_base = (u64::from(self.bars[bar_idx].addr & mask) << 32) | u64::from(self.bars[bar_idx - 1].addr & self.writable_bits[reg_idx - 1]); @@ -1043,8 +1043,8 @@ impl PciConfiguration { } info!( - "Detected ROM BAR reprogramming: (BAR {}) 0x{:x}->0x{:x}", - reg_idx, self.registers[reg_idx], value + "Detected ROM BAR reprogramming: (Expansion ROM BAR) 0x{:x}->0x{:x}", + self.rom_bar_addr, value ); let old_base = u64::from(self.rom_bar_addr & mask); let new_base = u64::from(value & mask);