From 5f04c9b6fea85c3f0a34da3bd6914727b8303060 Mon Sep 17 00:00:00 2001 From: Bo Chen Date: Tue, 9 Jan 2024 15:28:01 -0800 Subject: [PATCH] block: vhdx: Fix block size check warning: boolean expression will never evaluate to 'true' --> block/src/vhdx/vhdx_metadata.rs:136:20 | 136 | if disk_spec.block_size < BLOCK_SIZE_MIN && disk_spec.block_size > BLOCK_SIZE_MAX { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: since `BLOCK_SIZE_MIN` < `BLOCK_SIZE_MAX`, the expression evaluates to false for any value of `disk_spec.block_size` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#impossible_comparisons = note: `#[warn(clippy::impossible_comparisons)]` on by default && was used when || should have been used Signed-off-by: Rob Bradford Signed-off-by: Bo Chen (cherry picked from commit b74907fa1b92ef587a71b48798c7764d3d934994) --- vhdx/src/vhdx_metadata.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vhdx/src/vhdx_metadata.rs b/vhdx/src/vhdx_metadata.rs index ea5b632b4..4dc70d356 100644 --- a/vhdx/src/vhdx_metadata.rs +++ b/vhdx/src/vhdx_metadata.rs @@ -133,7 +133,7 @@ impl DiskSpec { .map_err(VhdxMetadataError::ReadMetadata)?; // MUST be at least 1 MiB and not greater than 256 MiB - if disk_spec.block_size < BLOCK_SIZE_MIN && disk_spec.block_size > BLOCK_SIZE_MAX { + if disk_spec.block_size < BLOCK_SIZE_MIN || disk_spec.block_size > BLOCK_SIZE_MAX { return Err(VhdxMetadataError::InvalidBlockSize); }