From 5f4ad4bb1e78d5311b692dccb153259b9c6be395 Mon Sep 17 00:00:00 2001 From: Muminul Islam Date: Sat, 21 Mar 2026 16:08:51 -0700 Subject: [PATCH] tests: extract _test_dmi_serial_number to tests_wrappers Move the DMI serial number test logic from integration.rs into a shared _test_dmi_serial_number() function in tests_wrappers.rs. The original test now delegates to this shared function, enabling reuse by CVM tests. Signed-off-by: Muminul Islam --- .../tests/common/tests_wrappers.rs | 30 +++++++++++++++++ cloud-hypervisor/tests/integration.rs | 32 ++----------------- 2 files changed, 32 insertions(+), 30 deletions(-) diff --git a/cloud-hypervisor/tests/common/tests_wrappers.rs b/cloud-hypervisor/tests/common/tests_wrappers.rs index 2663a6499..053cdf441 100644 --- a/cloud-hypervisor/tests/common/tests_wrappers.rs +++ b/cloud-hypervisor/tests/common/tests_wrappers.rs @@ -2180,3 +2180,33 @@ pub fn _test_split_irqchip(guest: &Guest) { handle_child_output(r, &output); } + +#[cfg(target_arch = "x86_64")] +pub(crate) fn _test_dmi_serial_number(guest: &Guest) { + let mut child = GuestCommand::new(guest) + .default_cpus() + .default_memory() + .default_kernel_cmdline_with_platform(Some("serial_number=a=b;c=d")) + .default_disks() + .default_net() + .capture_output() + .spawn() + .unwrap(); + + let r = std::panic::catch_unwind(|| { + guest.wait_vm_boot().unwrap(); + + assert_eq!( + guest + .ssh_command("sudo cat /sys/class/dmi/id/product_serial") + .unwrap() + .trim(), + "a=b;c=d" + ); + }); + + kill_child(&mut child); + let output = child.wait_with_output().unwrap(); + + handle_child_output(r, &output); +} diff --git a/cloud-hypervisor/tests/integration.rs b/cloud-hypervisor/tests/integration.rs index 1b6562fab..9cb2dc209 100644 --- a/cloud-hypervisor/tests/integration.rs +++ b/cloud-hypervisor/tests/integration.rs @@ -1738,37 +1738,9 @@ mod common_parallel { #[test] #[cfg(target_arch = "x86_64")] fn test_dmi_serial_number() { - let disk_config = UbuntuDiskConfig::new(JAMMY_IMAGE_NAME.to_string()); - let guest = Guest::new(Box::new(disk_config)); + let guest = basic_regular_guest!(JAMMY_IMAGE_NAME); - let mut child = GuestCommand::new(&guest) - .default_cpus() - .default_memory() - .args(["--kernel", direct_kernel_boot_path().to_str().unwrap()]) - .args(["--cmdline", DIRECT_KERNEL_BOOT_CMDLINE]) - .args(["--platform", "serial_number=a=b;c=d"]) - .default_disks() - .default_net() - .capture_output() - .spawn() - .unwrap(); - - let r = std::panic::catch_unwind(|| { - guest.wait_vm_boot().unwrap(); - - assert_eq!( - guest - .ssh_command("sudo cat /sys/class/dmi/id/product_serial") - .unwrap() - .trim(), - "a=b;c=d" - ); - }); - - kill_child(&mut child); - let output = child.wait_with_output().unwrap(); - - handle_child_output(r, &output); + _test_dmi_serial_number(&guest); } #[test]