kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

block: qcow: Make the qcow sync worker tests positional

Browse Source 
Convert the qcow sync worker test helpers to positional access instead
of the cursor. Test only change.

Assisted-by: Claude:Opus-4.8
Signed-off-by: Anatol Belski <anbelski@linux.microsoft.com>
This commit is contained in:
Anatol Belski
2026-07-02 22:57:49 +02:00
committed by Rob Bradford
parent 62bdf2b209
commit 6be2a52d14
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
block/src/formats/qcow/worker/sync.rs
+5 -7
View File
@@ -306,7 +306,8 @@ impl AsyncIo for QcowSync {
#[cfg(test)] #[cfg(test)]
mod unit_tests { mod unit_tests {
use std::fs::{File, OpenOptions, create_dir}; use std::fs::{File, OpenOptions, create_dir};
use std::io::{Read, Seek, SeekFrom, Write}; use std::io::Write;
use std::os::unix::fs::FileExt;
use std::path::Path; use std::path::Path;
use std::sync::Arc; use std::sync::Arc;
use std::{env, thread}; use std::{env, thread};
@@ -335,14 +336,12 @@ mod unit_tests {
fn read_be_u64_at(file: &mut File, offset: u64) -> u64 { fn read_be_u64_at(file: &mut File, offset: u64) -> u64 {
let mut bytes = [0u8; 8]; let mut bytes = [0u8; 8];
file.seek(SeekFrom::Start(offset)).unwrap(); file.read_exact_at(&mut bytes, offset).unwrap();
file.read_exact(&mut bytes).unwrap();
u64::from_be_bytes(bytes) u64::from_be_bytes(bytes)
} }
fn write_be_u64_at(file: &mut File, offset: u64, value: u64) { fn write_be_u64_at(file: &mut File, offset: u64, value: u64) {
file.seek(SeekFrom::Start(offset)).unwrap(); file.write_all_at(&value.to_be_bytes(), offset).unwrap();
file.write_all(&value.to_be_bytes()).unwrap();
} }
fn first_l2_entry_offset(file: &mut File) -> u64 { fn first_l2_entry_offset(file: &mut File) -> u64 {
@@ -997,8 +996,7 @@ mod unit_tests {
raw.sync_all().unwrap(); raw.sync_all().unwrap();
} }
let mut overlay_file = overlay_temp.into_file(); let overlay_file = overlay_temp.into_file();
overlay_file.rewind().unwrap();
let err = QcowDisk::new(overlay_file, false, true, true, false).unwrap_err(); let err = QcowDisk::new(overlay_file, false, true, true, false).unwrap_err();
assert!(matches!(err.kind(), BlockErrorKind::Io)); assert!(matches!(err.kind(), BlockErrorKind::Io));