From 6de472f1bba98ab544bd23abee47b390beed1c0e Mon Sep 17 00:00:00 2001 From: Julian Schindel Date: Wed, 29 Apr 2026 21:55:06 +0200 Subject: [PATCH] pci: replace `as ` casts with safer alternatives `as` casts can change mutability, which quickly leads to undefined behavior. Signed-off-by: Julian Schindel --- pci/src/mmap.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pci/src/mmap.rs b/pci/src/mmap.rs index 79d3ab20b..1a239f3a9 100644 --- a/pci/src/mmap.rs +++ b/pci/src/mmap.rs @@ -26,7 +26,7 @@ pub struct MmapRegion { impl Drop for MmapRegion { fn drop(&mut self) { // SAFETY: guaranteed by type validity invariant - unsafe { assert_eq!(libc::munmap(self.addr as *mut _, self.len), 0) } + unsafe { assert_eq!(libc::munmap(self.addr.cast(), self.len), 0) } } } // SAFETY: the caller is responsible for avoiding data races @@ -82,7 +82,7 @@ in both isize and libc::size_t"; if addr == libc::MAP_FAILED { Err(Error::last_os_error()) } else { - let addr = addr as _; + let addr = addr.cast(); Ok(Self { addr, len }) } }