From 6e501cc2dcfe1e379c7ab54f18e3c13120e16e0f Mon Sep 17 00:00:00 2001 From: Sebastian Eydam Date: Tue, 14 Apr 2026 12:59:00 +0200 Subject: [PATCH] vmm: remove redundant SocketStream overrides ReadVolatile already provides a default read_volatile_exact() implementation, and WriteVolatile a default write_volatile_exact() implementation. Overriding these functions adds no behavioral value, but duplicates logic and needs to be updated whenever SocketStream gains or changes a variant. On-behalf-of: SAP sebastian.eydam@sap.com Signed-off-by: Sebastian Eydam --- vmm/src/migration_transport.rs | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/vmm/src/migration_transport.rs b/vmm/src/migration_transport.rs index 15ff232ef..45e0f753d 100644 --- a/vmm/src/migration_transport.rs +++ b/vmm/src/migration_transport.rs @@ -153,16 +153,6 @@ impl ReadVolatile for SocketStream { SocketStream::Tcp(s) => s.read_volatile(buf), } } - - fn read_exact_volatile( - &mut self, - buf: &mut VolatileSlice, - ) -> Result<(), VolatileMemoryError> { - match self { - SocketStream::Unix(s) => s.read_exact_volatile(buf), - SocketStream::Tcp(s) => s.read_exact_volatile(buf), - } - } } impl WriteVolatile for SocketStream { @@ -175,16 +165,6 @@ impl WriteVolatile for SocketStream { SocketStream::Tcp(s) => s.write_volatile(buf), } } - - fn write_all_volatile( - &mut self, - buf: &VolatileSlice, - ) -> Result<(), VolatileMemoryError> { - match self { - SocketStream::Unix(s) => s.write_all_volatile(buf), - SocketStream::Tcp(s) => s.write_all_volatile(buf), - } - } } // Wait for `fd` to become readable. In this case, we return true. In case