From 70e926372a28cf66a70340152d995324dbccd3ce Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Mon, 26 Apr 2021 16:29:35 +0100 Subject: [PATCH] vhost_user_net: Don't advertise offload features In the reference vhost_user_net backend don't advertise the offload features. For correctness we should only advertise them if we can set them when they are acked by the guest. Signed-off-by: Rob Bradford --- vhost_user_net/src/lib.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/vhost_user_net/src/lib.rs b/vhost_user_net/src/lib.rs index 847e4e69e..137ed590b 100644 --- a/vhost_user_net/src/lib.rs +++ b/vhost_user_net/src/lib.rs @@ -176,13 +176,7 @@ impl VhostUserBackend for VhostUserNetBackend { } fn features(&self) -> u64 { - 1 << VIRTIO_NET_F_GUEST_CSUM - | 1 << VIRTIO_NET_F_CSUM - | 1 << VIRTIO_NET_F_GUEST_TSO4 - | 1 << VIRTIO_NET_F_GUEST_UFO - | 1 << VIRTIO_NET_F_HOST_TSO4 - | 1 << VIRTIO_NET_F_HOST_UFO - | 1 << VIRTIO_F_VERSION_1 + 1 << VIRTIO_F_VERSION_1 | 1 << VIRTIO_RING_F_EVENT_IDX | VhostUserVirtioFeatures::PROTOCOL_FEATURES.bits() }