kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmm: replace as <pointer> casts with safer alternatives

Browse Source 
`as` casts can change mutability, which quickly leads to undefined
behavior.

Signed-off-by: Julian Schindel <mail@arctic-alpaca.de>
This commit is contained in:
Julian Schindel
2026-04-29 21:55:06 +02:00
committed by Rob Bradford
parent cb09c37c55
commit 8b101fb890
6 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
vmm/src/memory_manager.rs
View File

@@ -1188,7 +1188,7 @@ impl MemoryManager {
let n = unsafe {
libc::read(
uffd_raw_fd,
&mut msg as *mut uffd::UffdMsg as *mut libc::c_void,
(&raw mut msg).cast(),
std::mem::size_of::<uffd::UffdMsg>(),
)
};
@@ -1824,7 +1824,7 @@ impl MemoryManager {
let res = unsafe {
libc::syscall(
libc::SYS_mbind,
addr as *mut libc::c_void,
addr.cast::<libc::c_void>(),
len,
mode,
nodemask.as_ptr(),
@@ -2002,7 +2002,7 @@ impl MemoryManager {
// SAFETY: FFI call with correct arguments
let ret = unsafe {
let addr = r.as_ptr().add(offset);
libc::madvise(addr as _, pages * page_size, libc::MADV_POPULATE_WRITE)
libc::madvise(addr.cast(), pages * page_size, libc::MADV_POPULATE_WRITE)
};
if ret != 0 {
let e = io::Error::last_os_error();
@@ -2021,7 +2021,7 @@ impl MemoryManager {
if thp && !hugepages {
// SAFETY: FFI call with correct arguments
let ret = unsafe { libc::madvise(region.as_ptr() as _, size, libc::MADV_HUGEPAGE) };
let ret = unsafe { libc::madvise(region.as_ptr().cast(), size, libc::MADV_HUGEPAGE) };
if ret != 0 {
let e = io::Error::last_os_error();
warn!("Failed to mark pages as THP eligible: {e}");
@@ -2319,7 +2319,7 @@ impl MemoryManager {
// mmap succeeded.
let ret = unsafe {
libc::madvise(
userspace_addr as *mut libc::c_void,
userspace_addr.cast(),
memory_size as libc::size_t,
libc::MADV_DONTDUMP,
)
@@ -2335,7 +2335,7 @@ impl MemoryManager {
// mmap succeeded.
let ret = unsafe {
libc::madvise(
userspace_addr as *mut libc::c_void,
userspace_addr.cast(),
memory_size as libc::size_t,
libc::MADV_MERGEABLE,
)
@@ -2400,7 +2400,7 @@ impl MemoryManager {
// previously advised.
let ret = unsafe {
libc::madvise(
userspace_addr as *mut libc::c_void,
userspace_addr.cast(),
memory_size as libc::size_t,
libc::MADV_UNMERGEABLE,
)