From b1d126fdbff5a7d2b843a1d41e489bf68f15f696 Mon Sep 17 00:00:00 2001
From: Anatol Belski <anbelski@linux.microsoft.com>
Date: Sat, 21 Mar 2026 17:22:30 +0100
Subject: [PATCH] block: qcow: Implement batch request submission

Implement batch_requests_enabled() and submit_batch_requests() for
QcowAsync. Without batching, each read_vectored call performs its own
io_uring submit() syscall. With batching, the virtio queue handler
collects all pending requests and submits them in a single call,
pushing multiple SQEs before one submit() syscall.

Each request in the batch is classified through the metadata layer.
Requests that hit the fast path (single allocated cluster mapping)
are pushed to the io_uring submission queue. Requests that require
the slow path (compressed, backing, zero fill, or mixed mappings)
are completed synchronously and queued as synthetic completions.

Signed-off-by: Anatol Belski <anbelski@linux.microsoft.com>
---
 block/src/qcow_async.rs | 80 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 79 insertions(+), 1 deletion(-)

diff --git a/block/src/qcow_async.rs b/block/src/qcow_async.rs
index b5720bdca..11e755461 100644
--- a/block/src/qcow_async.rs
+++ b/block/src/qcow_async.rs
@@ -19,7 +19,6 @@ use vmm_sys_util::eventfd::EventFd;
 use vmm_sys_util::write_zeroes::{PunchHole, WriteZeroesAt};
 
 use crate::async_io::{AsyncIo, AsyncIoError, AsyncIoResult, BorrowedDiskFd, DiskFileError};
-use crate::disk_file;
 use crate::error::{BlockError, BlockErrorKind, BlockResult, ErrorOp};
 use crate::qcow::backing::shared_backing_from;
 use crate::qcow::metadata::{
@@ -30,6 +29,7 @@ use crate::qcow::{MAX_NESTING_DEPTH, RawFile, parse_qcow};
 use crate::qcow_common::{
     gather_from_iovecs, pread_exact, pwrite_all, scatter_to_iovecs, zero_fill_iovecs,
 };
+use crate::{BatchRequest, RequestType, disk_file};
 
 /// Device level handle for a QCOW2 image.
 ///
@@ -355,6 +355,84 @@ impl AsyncIo for QcowAsync {
         // Both discard guest data so the range reads back as zero.
         self.punch_hole(offset, length, user_data)
     }
+
+    fn batch_requests_enabled(&self) -> bool {
+        true
+    }
+
+    fn submit_batch_requests(&mut self, batch_request: &[BatchRequest]) -> AsyncIoResult<()> {
+        let (submitter, mut sq, _) = self.io_uring.split();
+        let mut needs_submit = false;
+        let mut sync_completions: Vec<(u64, i32)> = Vec::new();
+
+        for req in batch_request {
+            match req.request_type {
+                RequestType::In => {
+                    let total_len: usize = req.iovecs.iter().map(|v| v.iov_len).sum();
+
+                    if let Some(host_offset) = Self::resolve_read(
+                        &self.metadata,
+                        &self.data_file,
+                        &self.backing_file,
+                        req.offset as u64,
+                        &req.iovecs,
+                        total_len,
+                    )? {
+                        let fd = self.data_file.as_raw_fd();
+                        // SAFETY: fd is valid and iovecs point to valid guest memory.
+                        unsafe {
+                            sq.push(
+                                &opcode::Readv::new(
+                                    types::Fd(fd),
+                                    req.iovecs.as_ptr(),
+                                    req.iovecs.len() as u32,
+                                )
+                                .offset(host_offset)
+                                .build()
+                                .user_data(req.user_data),
+                            )
+                            .map_err(|_| {
+                                AsyncIoError::ReadVectored(Error::other("Submission queue is full"))
+                            })?;
+                        }
+                        needs_submit = true;
+                    } else {
+                        sync_completions.push((req.user_data, total_len as i32));
+                    }
+                }
+                RequestType::Out => {
+                    let total_len: usize = req.iovecs.iter().map(|v| v.iov_len).sum();
+                    Self::cow_write_sync(
+                        req.offset as u64,
+                        &req.iovecs,
+                        &self.metadata,
+                        &self.data_file,
+                        &self.backing_file,
+                    )?;
+                    sync_completions.push((req.user_data, total_len as i32));
+                }
+                _ => {
+                    unreachable!("Unexpected batch request type: {:?}", req.request_type)
+                }
+            }
+        }
+
+        if needs_submit {
+            sq.sync();
+            submitter
+                .submit()
+                .map_err(AsyncIoError::SubmitBatchRequests)?;
+        }
+
+        if !sync_completions.is_empty() {
+            for c in sync_completions {
+                self.completion_list.push_back(c);
+            }
+            self.eventfd.write(1).unwrap();
+        }
+
+        Ok(())
+    }
 }
 
 impl QcowAsync {