kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

virtio-devices: modify or provide safety comments

Browse Source 
Signed-off-by: Wei Liu <liuwe@microsoft.com>
This commit is contained in:
Wei Liu
2022-11-16 22:42:25 +00:00
committed by Liu Wei
parent f110029acf
commit c45d24df16
12 changed files with 41 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
virtio-devices/src/vhost_user/vu_common_ctrl.rs
View File

@@ -451,7 +451,7 @@ impl VhostUserHandle {
)
.map_err(Error::MemfdCreate)?;
// Safe because we checked the file descriptor is valid
// SAFETY: we checked the file descriptor is valid
let file = unsafe { File::from_raw_fd(fd) };
// The size of the memory mapping corresponds to the size of a bitmap
// covering all guest pages for addresses from 0 to the last physical
@@ -465,6 +465,7 @@ impl VhostUserHandle {
file.set_len(mmap_size).map_err(Error::SetFileSize)?;
// Set the seals
// SAFETY: FFI call with valid arguments
let res = unsafe {
libc::fcntl(
file.as_raw_fd(),
@@ -569,6 +570,7 @@ impl VhostUserHandle {
// Be careful with the size, as it was based on u8, meaning we must
// divide it by 8.
let len = region.size() / 8;
// SAFETY: region is of size len
let bitmap = unsafe {
// Cast the pointer to u64
let ptr = region.as_ptr() as *const u64;
@@ -582,6 +584,7 @@ impl VhostUserHandle {
}
fn memfd_create(name: &ffi::CStr, flags: u32) -> std::result::Result<RawFd, std::io::Error> {
// SAFETY: FFI call with valid arguments
let res = unsafe { libc::syscall(libc::SYS_memfd_create, name.as_ptr(), flags) };
if res < 0 {