kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

tracer: avoid unnecessary allocations

Browse Source 
Allocation is only required when creating a new entry in the hashmap.

Signed-off-by: Wei Liu <liuwe@microsoft.com>
This commit is contained in:
Wei Liu
2022-11-17 10:54:16 +00:00
committed by Rob Bradford
parent f52cd3bb85
commit c9483fb080
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tracer/src/tracer.rs
+13 -9
View File
@@ -52,9 +52,10 @@ impl Tracer {
} }
fn add_event(&mut self, event: TraceEvent) { fn add_event(&mut self, event: TraceEvent) {
let thread_name = std::thread::current().name().unwrap_or("").to_string(); let current = std::thread::current();
let thread_name = current.name().unwrap_or("");
let mut events = self.events.lock().unwrap(); let mut events = self.events.lock().unwrap();
if let Some(thread_events) = events.get_mut(&thread_name) { if let Some(thread_events) = events.get_mut(thread_name) {
thread_events.push(event); thread_events.push(event);
} else { } else {
events.insert(thread_name.to_string(), vec![event]); events.insert(thread_name.to_string(), vec![event]);
@@ -62,18 +63,20 @@ impl Tracer {
} }
fn increase_thread_depth(&mut self) { fn increase_thread_depth(&mut self) {
let thread_name = std::thread::current().name().unwrap_or("").to_string(); let current = std::thread::current();
if let Some(depth) = self.thread_depths.get_mut(&thread_name) { let thread_name = current.name().unwrap_or("");
if let Some(depth) = self.thread_depths.get_mut(thread_name) {
depth.fetch_add(1, Ordering::SeqCst); depth.fetch_add(1, Ordering::SeqCst);
} else { } else {
self.thread_depths self.thread_depths
.insert(thread_name, Arc::new(AtomicU64::new(0))); .insert(thread_name.to_string(), Arc::new(AtomicU64::new(0)));
} }
} }
fn decrease_thread_depth(&mut self) { fn decrease_thread_depth(&mut self) {
let thread_name = std::thread::current().name().unwrap_or("").to_string(); let current = std::thread::current();
if let Some(depth) = self.thread_depths.get_mut(&thread_name) { let thread_name = current.name().unwrap_or("");
if let Some(depth) = self.thread_depths.get_mut(thread_name) {
depth.fetch_sub(1, Ordering::SeqCst); depth.fetch_sub(1, Ordering::SeqCst);
} else { } else {
panic!("Unmatched decreas for thread: {}", thread_name); panic!("Unmatched decreas for thread: {}", thread_name);
@@ -81,9 +84,10 @@ impl Tracer {
} }
fn thread_depth(&self) -> u64 { fn thread_depth(&self) -> u64 {
let thread_name = std::thread::current().name().unwrap_or("").to_string(); let current = std::thread::current();
let thread_name = current.name().unwrap_or("");
self.thread_depths self.thread_depths
.get(&thread_name) .get(thread_name)
.map(|v| v.load(Ordering::SeqCst)) .map(|v| v.load(Ordering::SeqCst))
.unwrap_or_default() .unwrap_or_default()
} }